-
Notifications
You must be signed in to change notification settings - Fork 237
[ENH] Add capability:predict_proba tag for classifiers #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Reference Issues/PRs
Fixes #1599
What does this implement/fix? Explain your changes.
This PR implements the
capability:predict_probatag to distinguish between classifiers that provide meaningful probability estimates and those that strictly return 0/1, such as 1-Nearest Neighbor.Specific changes:
capability:predict_probato the default tags, set to True.__init__to dynamically set this tag to False whenn_neighbors=1.__init__to ensure the pipeline inherits this tag from its underlying classifier instance, fixing polymorphic behavior.aeon/classification/tests/test_predict_proba_tag.pyto verify that tags are correctly set for 1-NN vs 5-NN and correctly propagated through pipelines.Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access