Improvements #137
Open
Improvements #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test explicit failure in `parse_result`. We identified that this function can fail with various I/O errors. In the case of a failure, the retry mechanism is not invoked. This can cause unexpected failures in the client if servers in the cluster fail when reading the result of a command.
- Handle almost all exceptions and retry. - Add backoff during retry to avoid congestion. - Increase default `max_retries` to 3.
Aerospike has some tricky exception handling where some kinds of result codes represent fatal errors which no amount of retrying will help. We need to differentiate these so that the retry mechanism immediately fails in those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a list of improvements, that have been implemented in our fork for the ruby client since we started using Aerospike. We've been running them in production for several years already.
If they look reasonable to you, please consider merging them to the main repo.