Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Bevy UI backend so it ignores clipped areas of UI nodes #285

Merged
merged 6 commits into from
Feb 23, 2024

Conversation

ickshonpe
Copy link
Contributor

The Bevy UI backend doesn't check for clipping, and allows interaction with clipped non-visible sections of UI nodes.

This PR intersects the node rect with its calculated clip rect (if it has one) and then checks if the clipped node contains the cursor.

…n with clipped non-visible sections of UI nodes.

This PR intersects the node rect with its calculated clip rect (if it has one) and then checks if the clipped node contains the cursor.
Copy link
Owner

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a clippy fix before this can merge. Thank you!

@ickshonpe
Copy link
Contributor Author

ickshonpe commented Dec 11, 2023

Looks good, but needs a clippy fix before this can merge. Thank you!

Sorry, it should be fixed now.

@aevyrie aevyrie enabled auto-merge (squash) February 23, 2024 21:07
@aevyrie aevyrie merged commit 7aafa82 into aevyrie:main Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants