Close if empty html #124
Open
Close if empty html #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stimulus-autocomplete ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
elalemanyo
commented
Feb 13, 2023
|
@ACPK did you check the example? https://github.com/afcapel/stimulus-autocomplete/pull/124/files |
|
@elalemanyo Yes but the Rails example should be updated to reflect the change. I found that Doesn't work: It could be resolved in Rails 7 by adding the following code to the controller. Works: |
|
@afcapel Is there any possibility to merge this? We believe it could be of interest to other users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes more sense to open the results only when there are results. In my case, this resulted in some style inconsistencies.