docs(i18n): add German (de-DE) localization scout#2029
Conversation
Adds the German locale per maintainer guidance in issue affaan-m#1980. - docs/de-DE/README.md: full translation of the English root README - docs/de-DE/GLOSSARY.md: German terminology decisions (which ECC terms stay English vs. German) - manifests: docs-de-de module + locale:de-de component, modelled on the existing docs-zh-tw / locale:zh-tw entries - scripts/lib/install-manifests.js: de-DE in SUPPORTED_LOCALES, plus de-DE and de aliases so `--locale de` and `--locale de-DE` resolve - tests/lib/locale-install.test.js: focused de-DE coverage - Deutsch added to the language selector tables in all 10 existing READMEs (root + 9 localized) Refs affaan-m#1980
The npm-publish-surface test asserts package.json `files` aligns with the install module graph. The new docs-de-de module requires docs/de-DE in the published files list. Refs affaan-m#1980
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds full German (de-DE) localization: a comprehensive German README and glossary, installation manifest/module and packaging updates, installer script locale aliasing, language-selector links across translated READMEs, and tests validating German locale install planning and dry-run behavior. ChangesGerman (de-DE) Localization and Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/de-DE/GLOSSARY.md`:
- Around line 15-16: Several glossary entries use an opening German quote „ but
end with ASCII straight quotes " causing inconsistent rendering; update the
closing quotes to the proper German closing quotation mark “ (U+201C) for each
affected entry such as the "Command | Command ..." and "Rule | Rule ..." lines
and similarly for the entries noted at lines 24, 25, 28, and 40 so every opening
„ is paired with closing “.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 273a180a-bd9f-44df-bb04-298b089f04e0
📒 Files selected for processing (17)
README.mdREADME.zh-CN.mddocs/de-DE/GLOSSARY.mddocs/de-DE/README.mddocs/ja-JP/README.mddocs/ko-KR/README.mddocs/pt-BR/README.mddocs/ru/README.mddocs/th/README.mddocs/tr/README.mddocs/vi-VN/README.mddocs/zh-TW/README.mdmanifests/install-components.jsonmanifests/install-modules.jsonpackage.jsonscripts/lib/install-manifests.jstests/lib/locale-install.test.js
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Per CodeRabbit review on PR affaan-m#2029: pair the opening „ with the proper closing “ in GLOSSARY.md (was closing with an ASCII straight quote). Also normalise the one stray „..." in README.md to ASCII quotes, consistent with the rest of that file (it quotes a literal error string). Refs affaan-m#1980
|
@coderabbitai Fixed in 2b84740.
Verified: no remaining mixed |
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
Tip For best results, initiate chat on the files or code changes.
🐇 ✨ |
1 participant
What Changed
German (de-DE) localization scout, following the maintainer guidance in #1980.
New files
docs/de-DE/README.md— full German translation of the English rootREADME.md. English source:1e8c7e7(main HEAD when this branch was cut). Scope: the complete root README — all sections, the full changelog, every install path, key concepts, all per-harness sections, the FAQ. Relative links rewritten for thedocs/de-DE/depth; both language-selector tables list every locale including Deutsch.docs/de-DE/GLOSSARY.md— German terminology, modelled ondocs/ja-JP/GLOSSARY.md. Explicitly records which ECC terms stay English (Agent, Skill, Hook, Command, Rule, Harness, Instinct, Plugin, Marketplace, Worktree, Subagent, Frontmatter) and which take German forms.Installer registration (kept in this PR since it stays small, per the issue)
manifests/install-modules.json—docs-de-demodule.manifests/install-components.json—locale:de-decomponent.scripts/lib/install-manifests.js—de-DEinSUPPORTED_LOCALES;de-DE+dealiases inLOCALE_ALIAS_TO_COMPONENT_ID, so--locale deand--locale de-DEboth resolve.package.json—docs/de-DE/added to thefilespublish surface (required bynpm-publish-surface.test.js, which alignsfileswith the module graph).tests/lib/locale-install.test.js— focused de-DE coverage (catalog entry, plan resolution,--locale dedry-run).Discoverability
Deutschadded to the language selector tables in the rootREADME.md,README.zh-CN.md, and all 8docs/<locale>/README.mdfiles.One deviation from the issue, flagged: the issue listed
targets: ["claude"], but all eight existing docs modules (docs-ja-jp…docs-zh-tw) usetargets: ["claude", "claude-project"]. Following "the module should follow the existing docs modules", I matched the existing eight. Glad to switch to["claude"]only if you'd prefer.Why This Change
#1980 confirmed German is wanted and the locale set is not capped. This is the scout PR requested there. Per-domain
docs/de-DE/{agents,commands,rules,skills}/translations are intentionally left for incremental follow-up PRs to avoid a 300-file localization PR.Testing Done
node tests/run-all.js)node tests/run-all.js→ 2570 passed, 0 failed.Installer-backed checks named in the issue:
node tests/lib/locale-install.test.js→ 7 passed (2 new de-DE tests)node tests/lib/install-manifests.test.js→ 39 passednode scripts/ci/validate-install-manifests.js→ clean (30 modules, 74 components, 6 profiles)npx markdownlint-cli 'docs/de-DE/**/*.md'→ cleanType of Change
docs:Documentationfeat:New feature — installer locale registrationSecurity & Quality Checklist
Documentation
Refs #1980
Summary by cubic
Adds German (de-DE) docs and installer support, including a full translated README and a glossary. Addresses #1980’s scout localization and makes German available via the installer.
New Features
docs/de-DE/README.md(full translation) anddocs/de-DE/GLOSSARY.md.docs-de-demodule andlocale:de-decomponent;de/de-DEaliases;de-DEinSUPPORTED_LOCALES; targets["claude", "claude-project"].docs/de-DE/topackage.jsonfiles.README.mds.tests/lib/locale-install.test.jsfor plan resolution and catalog.Bug Fixes
docs/de-DE/GLOSSARY.md; normalized one quoted error string indocs/de-DE/README.md.Written for commit 2b84740. Summary will update on new commits. Review in cubic
Summary by CodeRabbit
New Features
Documentation
Tests