-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
feat: v1.8.0 harness release (core reliability + parity + new commands) #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,682
−776
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
48b883d
feat: deliver v1.8.0 harness reliability and parity updates
affaan-m f94707d
fix(commands): make ace-tool MCP optional in multi-* commands with bu…
98643ef
Add Contributor Covenant Code of Conduct
pangerlkr 57eb936
docs: add upstream tracking flag to push example
61485f9
feat(CLI): Add Antigravity IDE support via `--target antigravity` flag
5e14722
Update install.sh
dawngnd c4a5a69
docs: strengthen sponsor optics with live metrics and tiers
affaan-m 5fe40f4
docs: add sponsorship playbook and monthly metrics automation
affaan-m d1f44e8
fix: stabilize windows hook and claw tests
affaan-m 1f8b3ea
fix: normalize hook command execution in integration tests
affaan-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,72 @@ | ||
| #!/usr/bin/env node | ||
| const { readStdin } = require('./adapter'); | ||
| const { readStdin, hookEnabled } = require('./adapter'); | ||
|
|
||
| function splitShellSegments(command) { | ||
| const segments = []; | ||
| let current = ''; | ||
| let quote = null; | ||
|
|
||
| for (let i = 0; i < command.length; i++) { | ||
| const ch = command[i]; | ||
| if (quote) { | ||
| if (ch === quote) quote = null; | ||
| current += ch; | ||
| continue; | ||
| } | ||
|
|
||
| if (ch === '"' || ch === "'") { | ||
| quote = ch; | ||
| current += ch; | ||
| continue; | ||
| } | ||
|
|
||
| const next = command[i + 1] || ''; | ||
| if (ch === ';' || (ch === '&' && next === '&') || (ch === '|' && next === '|') || (ch === '&' && next !== '&')) { | ||
| if (current.trim()) segments.push(current.trim()); | ||
| current = ''; | ||
| if ((ch === '&' && next === '&') || (ch === '|' && next === '|')) i++; | ||
| continue; | ||
| } | ||
|
|
||
| current += ch; | ||
| } | ||
|
|
||
| if (current.trim()) segments.push(current.trim()); | ||
| return segments; | ||
| } | ||
|
|
||
| readStdin().then(raw => { | ||
| try { | ||
| const input = JSON.parse(raw); | ||
| const cmd = input.command || ''; | ||
|
|
||
| // 1. Block dev server outside tmux | ||
| if (process.platform !== 'win32' && /(npm run dev\b|pnpm( run)? dev\b|yarn dev\b|bun run dev\b)/.test(cmd)) { | ||
| console.error('[ECC] BLOCKED: Dev server must run in tmux for log access'); | ||
| console.error('[ECC] Use: tmux new-session -d -s dev "npm run dev"'); | ||
| process.exit(2); | ||
| const input = JSON.parse(raw || '{}'); | ||
| const cmd = String(input.command || input.args?.command || ''); | ||
|
|
||
| if (hookEnabled('pre:bash:dev-server-block', ['standard', 'strict']) && process.platform !== 'win32') { | ||
| const segments = splitShellSegments(cmd); | ||
| const tmuxLauncher = /^\s*tmux\s+(new|new-session|new-window|split-window)\b/; | ||
| const devPattern = /\b(npm\s+run\s+dev|pnpm(?:\s+run)?\s+dev|yarn\s+dev|bun\s+run\s+dev)\b/; | ||
| const hasBlockedDev = segments.some(segment => devPattern.test(segment) && !tmuxLauncher.test(segment)); | ||
| if (hasBlockedDev) { | ||
| console.error('[ECC] BLOCKED: Dev server must run in tmux for log access'); | ||
| console.error('[ECC] Use: tmux new-session -d -s dev "npm run dev"'); | ||
| process.exit(2); | ||
| } | ||
| } | ||
|
|
||
| // 2. Tmux reminder for long-running commands | ||
| if (process.platform !== 'win32' && !process.env.TMUX && | ||
| /(npm (install|test)|pnpm (install|test)|yarn (install|test)?|bun (install|test)|cargo build|make\b|docker\b|pytest|vitest|playwright)/.test(cmd)) { | ||
| if ( | ||
| hookEnabled('pre:bash:tmux-reminder', ['strict']) && | ||
| process.platform !== 'win32' && | ||
| !process.env.TMUX && | ||
| /(npm (install|test)|pnpm (install|test)|yarn (install|test)?|bun (install|test)|cargo build|make\b|docker\b|pytest|vitest|playwright)/.test(cmd) | ||
| ) { | ||
| console.error('[ECC] Consider running in tmux for session persistence'); | ||
| } | ||
|
|
||
| // 3. Git push review reminder | ||
| if (/git push/.test(cmd)) { | ||
| if (hookEnabled('pre:bash:git-push-reminder', ['strict']) && /\bgit\s+push\b/.test(cmd)) { | ||
| console.error('[ECC] Review changes before push: git diff origin/main...HEAD'); | ||
| } | ||
| } catch {} | ||
| } catch { | ||
| // noop | ||
| } | ||
|
|
||
| process.stdout.write(raw); | ||
| }).catch(() => process.exit(0)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
| #!/usr/bin/env node | ||
| const { readStdin, runExistingHook, transformToClaude } = require('./adapter'); | ||
| const { readStdin, runExistingHook, transformToClaude, hookEnabled } = require('./adapter'); | ||
| readStdin().then(raw => { | ||
| const input = JSON.parse(raw); | ||
| const input = JSON.parse(raw || '{}'); | ||
| const claudeInput = transformToClaude(input); | ||
| runExistingHook('session-end.js', claudeInput); | ||
| runExistingHook('evaluate-session.js', claudeInput); | ||
| if (hookEnabled('session:end:marker', ['minimal', 'standard', 'strict'])) { | ||
| runExistingHook('session-end-marker.js', claudeInput); | ||
| } | ||
| process.stdout.write(raw); | ||
| }).catch(() => process.exit(0)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| #!/usr/bin/env node | ||
| const { readStdin, runExistingHook, transformToClaude } = require('./adapter'); | ||
| const { readStdin, runExistingHook, transformToClaude, hookEnabled } = require('./adapter'); | ||
| readStdin().then(raw => { | ||
| const input = JSON.parse(raw); | ||
| const input = JSON.parse(raw || '{}'); | ||
| const claudeInput = transformToClaude(input); | ||
| runExistingHook('session-start.js', claudeInput); | ||
| if (hookEnabled('session:start', ['minimal', 'standard', 'strict'])) { | ||
| runExistingHook('session-start.js', claudeInput); | ||
| } | ||
| process.stdout.write(raw); | ||
| }).catch(() => process.exit(0)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,21 @@ | ||
| #!/usr/bin/env node | ||
| const { readStdin, runExistingHook, transformToClaude } = require('./adapter'); | ||
| const { readStdin, runExistingHook, transformToClaude, hookEnabled } = require('./adapter'); | ||
| readStdin().then(raw => { | ||
| const claudeInput = JSON.parse(raw || '{}'); | ||
| runExistingHook('check-console-log.js', transformToClaude(claudeInput)); | ||
| const input = JSON.parse(raw || '{}'); | ||
| const claudeInput = transformToClaude(input); | ||
|
|
||
| if (hookEnabled('stop:check-console-log', ['standard', 'strict'])) { | ||
| runExistingHook('check-console-log.js', claudeInput); | ||
| } | ||
| if (hookEnabled('stop:session-end', ['minimal', 'standard', 'strict'])) { | ||
| runExistingHook('session-end.js', claudeInput); | ||
| } | ||
| if (hookEnabled('stop:evaluate-session', ['minimal', 'standard', 'strict'])) { | ||
| runExistingHook('evaluate-session.js', claudeInput); | ||
| } | ||
| if (hookEnabled('stop:cost-tracker', ['minimal', 'standard', 'strict'])) { | ||
| runExistingHook('cost-tracker.js', claudeInput); | ||
| } | ||
|
|
||
| process.stdout.write(raw); | ||
| }).catch(() => process.exit(0)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| changelog: | ||
| categories: | ||
| - title: Core Harness | ||
| labels: | ||
| - enhancement | ||
| - feature | ||
| - title: Reliability & Bug Fixes | ||
| labels: | ||
| - bug | ||
| - fix | ||
| - title: Docs & Guides | ||
| labels: | ||
| - docs | ||
| - title: Tooling & CI | ||
| labels: | ||
| - ci | ||
| - chore | ||
| exclude: | ||
| labels: | ||
| - skip-changelog |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
splitShellSegmentsdoesn't handle backslash escapes, which can produce incorrect segments for commands containing\",\',\;, or\&. This could cause the dev-server block to misfire or be bypassed. Consider skipping the character after a\when not inside single quotes (where backslash is literal in shell).Prompt for AI agents