feat: add everything-claude-code skill (#335)#372
Merged
Conversation
* feat: add everything-claude-code skill generated by ECC Tools * feat: add everything-claude-code instincts for continuous learning --------- Co-authored-by: ecc-tools[bot] <257055122+ecc-tools[bot]@users.noreply.github.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds two new repository artifacts: a YAML file defining curated "Everything Claude Code" instincts (rules/triggers/actions/evidence) and a SKILL.md describing the corresponding skill, usage, conventions, and update/release procedures. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml">
<violation number="1" location=".claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml:18">
P2: Contradictory guidance: this instinct says ~50 characters, but its own evidence states the average is 70 chars. A later instinct (`everything-claude-code-70-char-commit-length`) also says ~70 characters. Either reconcile these into a single instinct or fix the action to match the evidence.</violation>
<violation number="2" location=".claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml:98">
P1: Auto-generation artifact: "Use unknown as the test framework" is nonsensical guidance. The generator failed to detect the test framework and emitted the placeholder `unknown` as a literal value. This instinct should be removed or corrected with the actual test framework (the project uses a custom `node tests/run-all.js` runner per the PR checklist).</violation>
<violation number="3" location=".claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml:351">
P2: The second half of this file (starting here) is largely a duplicate of the first half with different IDs. There are ~10 pairs of instincts that convey the same guidance (e.g., file naming, export style, test types, commit length, and all major workflows). This appears to be two generation passes concatenated together. Deduplicate to avoid redundant/conflicting guidance.</violation>
</file>
<file name=".claude/skills/everything-claude-code/SKILL.md">
<violation number="1" location=".claude/skills/everything-claude-code/SKILL.md:18">
P2: The example contradicts the stated naming convention. The rule says "Use **kebab-case** for directories" but the example shows `skills/continuousLearningV2/SKILL.md` (camelCase). Every actual skill directory in the repo uses kebab-case. This should be `skills/continuous-learning-v2/SKILL.md` to match both the rule and existing code.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
Outdated
Show resolved
Hide resolved
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
Outdated
Show resolved
Hide resolved
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32a3efe0ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+208
to
+212
| | `/sync-docs` | Synchronize documentation across all language versions | | ||
| | `/sync-platforms` | Port changes across AI coding platforms | | ||
| | `/add-skill` | Add new skill with full cross-platform support | | ||
| | `/release` | Prepare and publish new version release | | ||
| | `/update-hooks` | Modify hook system and test integration | |
There was a problem hiding this comment.
The skill advertises /sync-docs, /sync-platforms, /add-skill, and related commands, but none of these command names are defined in this repository (the commands/*.md set contains names like /update-docs and /skill-create instead). When this skill is used, following these workflow commands will fail with unknown-command errors, so the documented workflow is not executable.
Useful? React with 👍 / 👎.
| ## Coding Conventions | ||
|
|
||
| ### File Naming | ||
| - Use **camelCase** for JavaScript files |
There was a problem hiding this comment.
The file-naming guidance says JavaScript files should be camelCase, but this repository’s JS files are consistently kebab-case (for example scripts/setup-package-manager.js and scripts/ci/validate-skills.js). Leaving this rule as-is will steer future generated edits toward a naming style that conflicts with the existing codebase and increases avoidable review churn.
Useful? React with 👍 / 👎.
|
|
||
| ## Action | ||
|
|
||
| Use unknown as the test framework |
There was a problem hiding this comment.
This instinct tells users to "Use unknown as the test framework," which is not an actionable framework and conflicts with the actual test flow in this repo (npm test runs concrete Node-based validation/test scripts). Importing this high-confidence instinct will inject misleading testing guidance into continuous-learning outputs.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
.claude/skills/everything-claude-code/SKILL.md (1)
1-215: Add the standard skill scaffolding headings.The content is useful, but it skips the usual
When to Use,How It Works, andExamplessections that repo skills are expected to expose. Folding the current overview/workflows/examples under that scaffold will make this easier to consume.Based on learnings: Applies to skills/**/*.md : Skills should be formatted as Markdown with clear sections for When to Use, How It Works, and Examples
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/everything-claude-code/SKILL.md around lines 1 - 215, Add the standard skill scaffolding by inserting the three required top-level Markdown sections "When to Use", "How It Works", and "Examples" into SKILL.md and move or fold the existing Overview/Workflows/Examples content under the appropriate sections (e.g., put the short overview and trigger guidance under "When to Use", the architecture and step-by-step workflows under "How It Works", and the code/snippet blocks and command examples under "Examples"); ensure headings use Markdown H2/H3 as in other skills and keep existing headings like "Coding Conventions", "Workflows", and "Commands" nested or summarized within these new sections so the file conforms to the skills/**/*.md format expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
@.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml:
- Around line 6-23: The YAML defines conflicting commit-length guidance: the
instinct id "everything-claude-code-commit-length" sets ~50 chars while other
instincts set ~70, causing contradictory advice; pick a single canonical
commit-length value, update "everything-claude-code-commit-length" (or the other
duplicate instinct ids) to that value, remove or merge the duplicate instinct
entries so only one id controls commit-length guidance, and update the
Evidence/description to match the chosen length so the repo loads a single
consistent rule.
- Around line 26-44: The broad camelCase naming rule (id:
everything-claude-code-naming-files, trigger: "when creating a new file") is
firing for all new files; narrow it to only affect JavaScript by adding a
file/filter field or language selector (e.g., files:
["*.js","*.jsx","*.ts","*.tsx"] or language: "javascript") so it no longer
applies to skills, docs, or config artifacts—ensure this change aligns with the
later instinct scoped to JavaScript to avoid duplicate/conflicting rules.
- Around line 86-103: The instinct currently emits an explicit action "Use
unknown as the test framework" when detection fails (see id:
everything-claude-code-test-framework and action field); change it to not
recommend the literal token "unknown" — instead either suppress the instinct
when detection is inconclusive or change the action string to "inspect the
existing test config first" (or equivalent). Update the rule that produces
action in this YAML so failure paths check the detector result and emit a
no-op/suppressed outcome or the new inspection instruction rather than the
literal "unknown".
- Around line 5-649: The YAML file
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
contains Markdown/frontmatter and is causing YAML parse failures; rename the
file to .md (everything-claude-code-instincts.md) so the existing loader in
instinct-cli.py (which supports .md) will treat it correctly, and update any
references to the old filename in configs or tests to the new .md name.
In @.claude/skills/everything-claude-code/SKILL.md:
- Around line 96-107: The SKILL addition workflow references porting to
`.cursor/skills/{skillName}/SKILL.md` and
`.agents/skills/{skillName}/openai.yaml` but those platform copies are missing
for everything-claude-code; create the required artifacts by adding
`.cursor/skills/everything-claude-code/SKILL.md` (matching the root SKILL.md
content and examples) and a `.agents/skills/everything-claude-code/` directory
containing an `openai.yaml` manifest with the skill metadata, then update any
cross-references in the root `README.md` and the workflow list (lines 4–5) to
ensure these platform copies exist before merging.
---
Nitpick comments:
In @.claude/skills/everything-claude-code/SKILL.md:
- Around line 1-215: Add the standard skill scaffolding by inserting the three
required top-level Markdown sections "When to Use", "How It Works", and
"Examples" into SKILL.md and move or fold the existing
Overview/Workflows/Examples content under the appropriate sections (e.g., put
the short overview and trigger guidance under "When to Use", the architecture
and step-by-step workflows under "How It Works", and the code/snippet blocks and
command examples under "Examples"); ensure headings use Markdown H2/H3 as in
other skills and keep existing headings like "Coding Conventions", "Workflows",
and "Commands" nested or summarized within these new sections so the file
conforms to the skills/**/*.md format expectations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5e44f06c-4ec9-4019-9953-8098483ee969
📒 Files selected for processing (2)
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml.claude/skills/everything-claude-code/SKILL.md
Comment on lines
+5
to
+649
| --- | ||
| id: everything-claude-code-commit-length | ||
| trigger: "when writing a commit message" | ||
| confidence: 0.6 | ||
| domain: git | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Commit Length | ||
|
|
||
| ## Action | ||
|
|
||
| Write moderate-length commit messages (~50 characters) | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Average commit message length: 70 chars | ||
| - Based on 200 commits | ||
|
|
||
| --- | ||
| id: everything-claude-code-naming-files | ||
| trigger: "when creating a new file" | ||
| confidence: 0.8 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Naming Files | ||
|
|
||
| ## Action | ||
|
|
||
| Use camelCase naming convention | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Analyzed file naming patterns in repository | ||
| - Dominant pattern: camelCase | ||
|
|
||
| --- | ||
| id: everything-claude-code-export-style | ||
| trigger: "when exporting from a module" | ||
| confidence: 0.7 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Export Style | ||
|
|
||
| ## Action | ||
|
|
||
| Prefer mixed exports | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Export pattern analysis | ||
| - Dominant style: mixed | ||
|
|
||
| --- | ||
| id: everything-claude-code-test-separate | ||
| trigger: "when writing tests" | ||
| confidence: 0.8 | ||
| domain: testing | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Test Separate | ||
|
|
||
| ## Action | ||
|
|
||
| Place tests in the tests/ or __tests__/ directory, mirroring src structure | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Separate test directory pattern detected | ||
| - Tests live in dedicated test folders | ||
|
|
||
| --- | ||
| id: everything-claude-code-test-framework | ||
| trigger: "when writing tests" | ||
| confidence: 0.9 | ||
| domain: testing | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Test Framework | ||
|
|
||
| ## Action | ||
|
|
||
| Use unknown as the test framework | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Test framework detected: unknown | ||
| - File pattern: *.test.js | ||
|
|
||
| --- | ||
| id: everything-claude-code-test-naming | ||
| trigger: "when creating a test file" | ||
| confidence: 0.85 | ||
| domain: testing | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Test Naming | ||
|
|
||
| ## Action | ||
|
|
||
| Name test files using the pattern: *.test.js | ||
|
|
||
| ## Evidence | ||
|
|
||
| - File pattern: *.test.js | ||
| - Consistent across test files | ||
|
|
||
| --- | ||
| id: everything-claude-code-test-types | ||
| trigger: "when planning tests for a feature" | ||
| confidence: 0.7 | ||
| domain: testing | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Test Types | ||
|
|
||
| ## Action | ||
|
|
||
| Write unit, integration tests to match project standards | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Test types detected: unit, integration | ||
| - Coverage config: yes | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-database-migration | ||
| trigger: "when modifying the database schema or adding tables" | ||
| confidence: 0.65 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Database Migration | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the database-migration workflow: | ||
| 1. Create migration file | ||
| 2. Update schema definitions | ||
| 3. Generate/update types | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~3x per month | ||
| - Files: migrations/* | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-feature-development | ||
| trigger: "when implementing a new feature" | ||
| confidence: 0.9 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Feature Development | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the feature-development workflow: | ||
| 1. Add feature implementation | ||
| 2. Add tests for feature | ||
| 3. Update documentation | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~14x per month | ||
| - Files: .opencode/*, .opencode/plugins/*, .opencode/tools/* | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-multi-language-documentation-sync | ||
| trigger: "when doing multi language documentation sync" | ||
| confidence: 0.9 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Multi Language Documentation Sync | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the multi-language-documentation-sync workflow: | ||
| 1. Update English documentation | ||
| 2. Translate changes to zh-CN | ||
| 3. Translate changes to zh-TW | ||
| 4. Translate changes to ja-JP | ||
| 5. Update cross-references | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~10x per month | ||
| - Files: README.md, docs/zh-CN/*.md, docs/zh-TW/*.md | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-cross-platform-harness-sync | ||
| trigger: "when doing cross platform harness sync" | ||
| confidence: 0.9 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Cross Platform Harness Sync | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the cross-platform-harness-sync workflow: | ||
| 1. Update main platform files | ||
| 2. Port to .cursor/ directory | ||
| 3. Port to .codex/ directory | ||
| 4. Port to .opencode/ directory | ||
| 5. Update platform-specific configs | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~8x per month | ||
| - Files: .cursor/*, .codex/*, .opencode/* | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-skill-addition-workflow | ||
| trigger: "when doing skill addition workflow" | ||
| confidence: 0.8 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Skill Addition Workflow | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the skill-addition-workflow workflow: | ||
| 1. Create main skill SKILL.md | ||
| 2. Add to README.md | ||
| 3. Port to .cursor/skills/ | ||
| 4. Port to .agents/skills/ with openai.yaml | ||
| 5. Update package.json | ||
| 6. Add translations if needed | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~6x per month | ||
| - Files: skills/*/SKILL.md, README.md, .cursor/skills/*/SKILL.md | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-version-release-workflow | ||
| trigger: "when doing version release workflow" | ||
| confidence: 0.65 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Version Release Workflow | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the version-release-workflow workflow: | ||
| 1. Update package.json version | ||
| 2. Update .claude-plugin/ manifests | ||
| 3. Update .opencode/package.json | ||
| 4. Update README version references | ||
| 5. Update CHANGELOG.md | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~3x per month | ||
| - Files: package.json, .claude-plugin/plugin.json, .claude-plugin/marketplace.json | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-hook-system-updates | ||
| trigger: "when doing hook system updates" | ||
| confidence: 0.7 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Hook System Updates | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the hook-system-updates workflow: | ||
| 1. Update hooks/hooks.json | ||
| 2. Create/update hook scripts | ||
| 3. Port to .cursor/hooks/ | ||
| 4. Update tests/hooks/ or tests/integration/ | ||
| 5. Update hook documentation | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~4x per month | ||
| - Files: hooks/hooks.json, scripts/hooks/*.js, .cursor/hooks/*.js | ||
|
|
||
| --- | ||
| id: everything-claude-code-workflow-continuous-learning-updates | ||
| trigger: "when doing continuous learning updates" | ||
| confidence: 0.75 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Workflow Continuous Learning Updates | ||
|
|
||
| ## Action | ||
|
|
||
| Follow the continuous-learning-updates workflow: | ||
| 1. Update main continuous-learning-v2 skill | ||
| 2. Update observer scripts | ||
| 3. Port to platform-specific directories | ||
| 4. Update translations | ||
| 5. Update related commands | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Workflow detected from commit patterns | ||
| - Frequency: ~5x per month | ||
| - Files: skills/continuous-learning-v2/*, .cursor/skills/continuous-learning-v2/*, commands/evolve.md | ||
|
|
||
| --- | ||
| id: everything-claude-code-camel-case-files | ||
| trigger: "When creating new JavaScript files" | ||
| confidence: 0.85 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Camel Case Files | ||
|
|
||
| ## Action | ||
|
|
||
| Use camelCase naming convention | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Consistent camelCase pattern in codeStyle analysis | ||
| - Files follow camelCase in folderStructure | ||
|
|
||
| --- | ||
| id: everything-claude-code-pascal-case-classes | ||
| trigger: "When defining JavaScript classes" | ||
| confidence: 0.85 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Pascal Case Classes | ||
|
|
||
| ## Action | ||
|
|
||
| Use PascalCase naming convention | ||
|
|
||
| ## Evidence | ||
|
|
||
| - PascalCase classes specified in namingConventions | ||
| - Consistent pattern across codebase | ||
|
|
||
| --- | ||
| id: everything-claude-code-screaming-snake-constants | ||
| trigger: "When defining constants" | ||
| confidence: 0.85 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Screaming Snake Constants | ||
|
|
||
| ## Action | ||
|
|
||
| Use SCREAMING_SNAKE_CASE naming convention | ||
|
|
||
| ## Evidence | ||
|
|
||
| - SCREAMING_SNAKE_CASE constants in namingConventions | ||
| - Standard JavaScript practice | ||
|
|
||
| --- | ||
| id: everything-claude-code-try-catch-errors | ||
| trigger: "When handling potential errors" | ||
| confidence: 0.8 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Try Catch Errors | ||
|
|
||
| ## Action | ||
|
|
||
| Use try-catch blocks for error handling | ||
|
|
||
| ## Evidence | ||
|
|
||
| - try-catch style specified in errorHandling | ||
| - No custom error classes or global handlers detected | ||
|
|
||
| --- | ||
| id: everything-claude-code-unit-integration-tests | ||
| trigger: "When writing tests" | ||
| confidence: 0.8 | ||
| domain: testing | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Unit Integration Tests | ||
|
|
||
| ## Action | ||
|
|
||
| Create both unit and integration tests using *.test.js pattern | ||
|
|
||
| ## Evidence | ||
|
|
||
| - testTypes include unit and integration | ||
| - filePattern shows *.test.js convention | ||
|
|
||
| --- | ||
| id: everything-claude-code-conventional-commits | ||
| trigger: "When making commits" | ||
| confidence: 0.9 | ||
| domain: git | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Conventional Commits | ||
|
|
||
| ## Action | ||
|
|
||
| Use conventional commit format with prefixes: feat, fix, docs, chore, test, refactor | ||
|
|
||
| ## Evidence | ||
|
|
||
| - All commit examples follow conventional format | ||
| - Consistent prefixes across commit history | ||
|
|
||
| --- | ||
| id: everything-claude-code-70-char-commit-length | ||
| trigger: "When writing commit messages" | ||
| confidence: 0.75 | ||
| domain: git | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code 70 Char Commit Length | ||
|
|
||
| ## Action | ||
|
|
||
| Keep commit messages around 70 characters average length | ||
|
|
||
| ## Evidence | ||
|
|
||
| - averageLength shows 70 characters | ||
| - Commit examples align with this pattern | ||
|
|
||
| --- | ||
| id: everything-claude-code-multilang-docs-sync | ||
| trigger: "When updating core documentation or features" | ||
| confidence: 0.95 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Multilang Docs Sync | ||
|
|
||
| ## Action | ||
|
|
||
| Update English first, then translate to zh-CN, zh-TW, ja-JP and update cross-references | ||
|
|
||
| ## Evidence | ||
|
|
||
| - multi-language-documentation-sync workflow frequency ~10x/month | ||
| - Clear pattern in filesInvolved across language directories | ||
|
|
||
| --- | ||
| id: everything-claude-code-cross-platform-sync | ||
| trigger: "When adding new features or updating platform configurations" | ||
| confidence: 0.9 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Cross Platform Sync | ||
|
|
||
| ## Action | ||
|
|
||
| Port changes to .cursor/, .codex/, .opencode/, and .agents/ directories | ||
|
|
||
| ## Evidence | ||
|
|
||
| - cross-platform-harness-sync workflow frequency ~8x/month | ||
| - Multiple platform directories in architecture | ||
|
|
||
| --- | ||
| id: everything-claude-code-skill-structure | ||
| trigger: "When adding a new skill or capability" | ||
| confidence: 0.88 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Skill Structure | ||
|
|
||
| ## Action | ||
|
|
||
| Create SKILL.md in main skills/, port to platform-specific directories, update README.md and package.json | ||
|
|
||
| ## Evidence | ||
|
|
||
| - skill-addition-workflow frequency ~6x/month | ||
| - Consistent skill structure across platforms | ||
|
|
||
| --- | ||
| id: everything-claude-code-version-release-sync | ||
| trigger: "When preparing a new release" | ||
| confidence: 0.85 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Version Release Sync | ||
|
|
||
| ## Action | ||
|
|
||
| Update all package.json files, plugin manifests, README version references, and CHANGELOG.md | ||
|
|
||
| ## Evidence | ||
|
|
||
| - version-release-workflow frequency ~3x/month | ||
| - Multiple package.json files in different directories | ||
|
|
||
| --- | ||
| id: everything-claude-code-hook-system-testing | ||
| trigger: "When modifying hook behavior or adding new hooks" | ||
| confidence: 0.82 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Hook System Testing | ||
|
|
||
| ## Action | ||
|
|
||
| Update hooks.json, create/update scripts, port to .cursor/, and update corresponding tests | ||
|
|
||
| ## Evidence | ||
|
|
||
| - hook-system-updates workflow frequency ~4x/month | ||
| - hooks/ and tests/ directories in architecture | ||
|
|
||
| --- | ||
| id: everything-claude-code-learning-system-updates | ||
| trigger: "When enhancing continuous learning capabilities" | ||
| confidence: 0.87 | ||
| domain: workflow | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Learning System Updates | ||
|
|
||
| ## Action | ||
|
|
||
| Update main continuous-learning-v2 skill, port to platforms, update translations and related commands | ||
|
|
||
| ## Evidence | ||
|
|
||
| - continuous-learning-updates workflow frequency ~5x/month | ||
| - commands/evolve.md and instinct-*.md files referenced | ||
|
|
||
| --- | ||
| id: everything-claude-code-hybrid-module-organization | ||
| trigger: "When organizing code modules" | ||
| confidence: 0.75 | ||
| domain: architecture | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Hybrid Module Organization | ||
|
|
||
| ## Action | ||
|
|
||
| Use hybrid module organization with separate test location | ||
|
|
||
| ## Evidence | ||
|
|
||
| - moduleOrganization: hybrid | ||
| - testLocation: separate in architecture analysis | ||
|
|
||
| --- | ||
| id: everything-claude-code-mixed-import-export | ||
| trigger: "When writing import/export statements" | ||
| confidence: 0.7 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Mixed Import Export | ||
|
|
||
| ## Action | ||
|
|
||
| Use mixed import and export styles as appropriate for the context | ||
|
|
||
| ## Evidence | ||
|
|
||
| - importStyle: mixed and exportStyle: mixed in codeStyle | ||
| - Flexible approach across codebase | ||
|
|
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
file="$(fd -H 'everything-claude-code-instincts\.yaml$' .claude/homunculus/instincts/inherited | head -n1)"
[ -n "$file" ]
python - "$file" <<'PY'
import subprocess, sys
from pathlib import Path
path = Path(sys.argv[1])
try:
import yaml
except ImportError:
subprocess.check_call([sys.executable, "-m", "pip", "install", "--quiet", "PyYAML"])
import yaml
try:
list(yaml.safe_load_all(path.read_text()))
print(f"{path}: YAML parse OK")
except Exception as exc:
print(f"{path}: YAML parse failed -> {exc}")
PY
rg -n "ALLOWED_INSTINCT_EXTENSIONS|suffix\.lower\(\) in ALLOWED_INSTINCT_EXTENSIONS" skills/continuous-learning-v2/scripts/instinct-cli.pyRepository: affaan-m/everything-claude-code
Length of output: 472
Rename .yaml file to .md to resolve YAML parse failure.
This file contains YAML frontmatter (the --- blocks) followed by Markdown content, not valid YAML multi-document syntax. Standard YAML parsing fails at line 22 with "expected '', but found ''". The file-loading logic in instinct-cli.py already supports .md as an instinct extension, so renaming resolves both the syntax error and the tooling incompatibility.
🧰 Tools
🪛 YAMLlint (1.38.0)
[error] 22-22: syntax error: expected '', but found ''
(syntax)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
around lines 5 - 649, The YAML file
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
contains Markdown/frontmatter and is causing YAML parse failures; rename the
file to .md (everything-claude-code-instincts.md) so the existing loader in
instinct-cli.py (which supports .md) will treat it correctly, and update any
references to the old filename in configs or tests to the new .md name.
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+26
to
+44
| id: everything-claude-code-naming-files | ||
| trigger: "when creating a new file" | ||
| confidence: 0.8 | ||
| domain: code-style | ||
| source: repo-analysis | ||
| source_repo: https://github.com/affaan-m/everything-claude-code | ||
| --- | ||
|
|
||
| # Everything Claude Code Naming Files | ||
|
|
||
| ## Action | ||
|
|
||
| Use camelCase naming convention | ||
|
|
||
| ## Evidence | ||
|
|
||
| - Analyzed file naming patterns in repository | ||
| - Dominant pattern: camelCase | ||
|
|
Contributor
There was a problem hiding this comment.
Narrow the camelCase rule to JavaScript files.
Line 27 currently fires for any new file, even though the later instinct at Line 352 already scopes camelCase to JavaScript files. Keeping the broader version will push wrong names for skills, docs, and config artifacts.
✏️ Suggested edit
id: everything-claude-code-naming-files
-trigger: "when creating a new file"
+trigger: "when creating a new JavaScript file"
confidence: 0.8
domain: code-style
source: repo-analysis
source_repo: https://github.com/affaan-m/everything-claude-code
---
# Everything Claude Code Naming Files
## Action
-Use camelCase naming convention
+Use camelCase naming convention for JavaScript source filesAlso applies to: 351-369
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
around lines 26 - 44, The broad camelCase naming rule (id:
everything-claude-code-naming-files, trigger: "when creating a new file") is
firing for all new files; narrow it to only affect JavaScript by adding a
file/filter field or language selector (e.g., files:
["*.js","*.jsx","*.ts","*.tsx"] or language: "javascript") so it no longer
applies to skills, docs, or config artifacts—ensure this change aligns with the
later instinct scoped to JavaScript to avoid duplicate/conflicting rules.
.claude/homunculus/instincts/inherited/everything-claude-code-instincts.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+96
to
+107
| ### Skill Addition Workflow | ||
| **Trigger:** When adding a new skill or capability | ||
| **Command:** `/add-skill` | ||
|
|
||
| 1. Create main skill directory: `skills/{skillName}/` | ||
| 2. Write comprehensive `SKILL.md` with examples and usage | ||
| 3. Add skill reference to root `README.md` | ||
| 4. Port skill to `.cursor/skills/{skillName}/SKILL.md` | ||
| 5. Port to `.agents/skills/{skillName}/` with `openai.yaml` | ||
| 6. Update `package.json` with new skill metadata | ||
| 7. Add translations for skill name and description | ||
| 8. Test skill loading across all platforms |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
for dir in .cursor .agents .codex .opencode; do
if [ -d "$dir" ]; then
printf "\n[%s]\n" "$dir"
fd -H 'everything-claude-code' "$dir" || true
fi
doneRepository: affaan-m/everything-claude-code
Length of output: 119
Platform copies missing from .cursor and .agents.
The workflow at lines 4–5 requires porting the skill to .cursor/skills/everything-claude-code/SKILL.md and .agents/skills/everything-claude-code/ with openai.yaml, but these artifacts do not exist in the repository. The feature is incomplete across the platforms this document advertises and should not be merged until these copies are added.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/everything-claude-code/SKILL.md around lines 96 - 107, The
SKILL addition workflow references porting to
`.cursor/skills/{skillName}/SKILL.md` and
`.agents/skills/{skillName}/openai.yaml` but those platform copies are missing
for everything-claude-code; create the required artifacts by adding
`.cursor/skills/everything-claude-code/SKILL.md` (matching the root SKILL.md
content and examples) and a `.agents/skills/everything-claude-code/` directory
containing an `openai.yaml` manifest with the skill metadata, then update any
cross-references in the root `README.md` and the workflow list (lines 4–5) to
ensure these platform copies exist before merging.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/skills/everything-claude-code/SKILL.md">
<violation number="1" location=".claude/skills/everything-claude-code/SKILL.md:69">
P2: The example `session-start.js` uses kebab-case, contradicting the convention stated earlier in the same file ('Prefer camelCase for JavaScript and TypeScript module filenames'). Consider using `sessionStart.js` to stay consistent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ```text | ||
| skills/continuous-learning-v2/SKILL.md | ||
| commands/update-docs.md | ||
| scripts/hooks/session-start.js |
There was a problem hiding this comment.
P2: The example session-start.js uses kebab-case, contradicting the convention stated earlier in the same file ('Prefer camelCase for JavaScript and TypeScript module filenames'). Consider using sessionStart.js to stay consistent.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .claude/skills/everything-claude-code/SKILL.md, line 69:
<comment>The example `session-start.js` uses kebab-case, contradicting the convention stated earlier in the same file ('Prefer camelCase for JavaScript and TypeScript module filenames'). Consider using `sessionStart.js` to stay consistent.</comment>
<file context>
@@ -1,215 +1,97 @@
+```text
+skills/continuous-learning-v2/SKILL.md
+commands/update-docs.md
+scripts/hooks/session-start.js
+tests/hooks/hooks.test.js
</file context>
</details>
<a href="https://www.cubic.dev/action/fix/violation/21acf0cc-883c-496a-930f-730bd3882c71" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://cubic.dev/buttons/fix-with-cubic-dark.svg">
<source media="(prefers-color-scheme: light)" srcset="https://cubic.dev/buttons/fix-with-cubic-light.svg">
<img alt="Fix with Cubic" src="https://cubic.dev/buttons/fix-with-cubic-dark.svg">
</picture>
</a>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add everything-claude-code skill generated by ECC Tools
feat: add everything-claude-code instincts for continuous learning
Description
Type of Change
fix:Bug fixfeat:New featurerefactor:Code refactoringdocs:Documentationtest:Testschore:Maintenance/toolingci:CI/CD changesChecklist
node tests/run-all.js)Summary by cubic
Adds the
everything-claude-codeskill and inherited instincts to teach repo-specific patterns and enable continuous learning. Refines the skill content for clarity and alignment with current workflows.New Features
.claude/skills/everything-claude-code/SKILL.mdcovering commit style, naming, tests, cross-platform mirroring, releases, and continuous-learning workflows..claude/homunculus/instincts/inherited/everything-claude-code-instincts.yamlwith actionable instincts for commits, file/test naming, hooks updates, cross-platform sync, release sync, and learning curation.Bug Fixes
SKILL.mdto remove noise and tighten guidance (clear naming rules, mirror targets, release metadata, and test runner usage).Written for commit 0c2efb2. Summary will update on new commits.
Summary by CodeRabbit
Documentation
Chores