feat(commands): improve learn-eval with checklist-based holistic verdict

[affaan-m]

Summary

• carry forward the /learn-eval holistic-verdict improvements from #360
• address the reviewer-requested gaps by checking project-local skills for overlap and adding the explicit Improve then Save confirmation branch
• refresh onto current main and include the CI validator dependency fix so the branch validates on current runners

Supersedes

• supersedes feat(commands): improve learn-eval with checklist-based holistic verdict #360, which could not be updated directly despite maintainer edits being enabled

Test plan

• npm ci --ignore-scripts
• node scripts/ci/validate-agents.js
• node scripts/ci/validate-hooks.js
• node scripts/ci/validate-commands.js
• node scripts/ci/validate-skills.js
• node scripts/ci/validate-rules.js

---

Summary by cubic

Upgrades /learn-eval to a checklist-based, holistic verdict system that reduces duplicate skills and guides where and how to save knowledge. Improves reliability of CI validators on current runners.

• New Features

  • Replace numeric scoring with a checklist + 4-way verdict: Save / Improve then Save / Absorb into [X] / Drop.
  • Add overlap checks against project/global skills and MEMORY.md, and consider appending to existing skills.
  • Add verdict-specific confirmation flows and a concise output template.

• Dependencies

  • Workflows now install validation dependencies (npm ci --ignore-scripts) before running validators.
  • Bump ajv to ^8.18.0.

^{Written for commit c6e7552. Summary will update on new commits.}

Summary by CodeRabbit

Release Notes

• Documentation

  • Redesigned skill evaluation guide with a holistic verdict system (supporting Save, Improve then Save, Absorb, or Drop outcomes) and comprehensive pre-save verification steps.

• Chores

  • Enhanced CI/CD validation workflow with dependency installation improvements.
  • Updated development dependencies.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Two CI workflow files add npm dependency installation steps for validation jobs, documentation is updated to replace numeric evaluation rubrics with a holistic verdict checklist system, and the ajv dev dependency is updated from v8.17.0 to v8.18.0.

Changes

Cohort / File(s)	Summary
CI Workflows .github/workflows/ci.yml, .github/workflows/reusable-validate.yml	Added "Install validation dependencies" step running npm ci --ignore-scripts after Node.js setup in both the validate job and reusable workflow.
Documentation Update commands/learn-eval.md	Restructured evaluation process from 5-dimension numeric rubric to checklist-based holistic verdict system. Added verdict categories (Save, Improve then Save, Absorb, Drop), expanded quality gate section, and introduced design rationale and additional pre-save verification guidance.
Dependencies package.json	Updated ajv dev dependency from ^8.17.0 to ^8.18.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat(commands): improve learn-eval with checklist-based holistic verdict #360: Directly modifies commands/learn-eval.md with identical rubric-to-verdict transformation, suggesting parallel or dependent work on the same documentation.
• feat(commands): add learn-eval command #263: Previous changes to commands/learn-eval.md that this PR builds upon and expands.

Poem

🐰 With workflows now swift and dependencies bright,
The validation now checks things quite right!
From numbers to verdicts, a qualitative way,
The learn-eval docs see the light of the day! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: improving learn-eval documentation with a checklist-based holistic verdict system, which is the primary focus across the workflow files and the commands/learn-eval.md changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/pr-360-learn-eval-v2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 5 files

[affaan-m]

Superseded by #360, which is now merged on main. Closing this duplicate follow-up to keep review surface clean.