Add Data URL as a supported value type for gltf-model component #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrxz
reviewed
Jan 14, 2025
docs/components/gltf-model.md
Outdated
| |----------|---------------------------------------------| | ||
| | selector | Selector to an `<a-asset-item>` | | ||
| | string | `url()`-enclosed path to a glTF file | | ||
| | Data URL | data:application/octet-stream;base64,<data> | |
There was a problem hiding this comment.
The official model/gltf-binary mime type can be used as well.
There was a problem hiding this comment.
Yes indeed, let's use that one in the table. The application/octet-stream is a generic mimetype for any binary files. I also added a paragraph how to create a Data URL.
vincentfretin
force-pushed
the
gltf-model-data-url
branch
from
86854af to
dbe5cb6
Compare
dmarcos
reviewed
Jan 21, 2025
docs/components/gltf-model.md
Outdated
| @@ -78,6 +78,16 @@ file. | |||
| |----------|--------------------------------------| | |||
| | selector | Selector to an `<a-asset-item>` | | |||
| | string | `url()`-enclosed path to a glTF file | | |||
| | Data URL | data:model/gltf-binary;base64,<data> | | |||
There was a problem hiding this comment.
Not a typo, it's a placeholder, it means you replace it by the actually content of the base64 data of your model.
There was a problem hiding this comment.
If it's confusing to me it will be confusing to others too. above there is <a-asset-item>, yours doesn't refer to HTML. Can we put it in a wat it's not ambiguous?
There was a problem hiding this comment.
Okay, I replaced by "..."
vincentfretin
force-pushed
the
gltf-model-data-url
branch
from
dbe5cb6 to
703ff48
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Discussed in #5619, Data URL is supported for gltf-model component but not currently documented.
Changes proposed: