Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Cardboard in documentation #5639

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

vincentfretin
Copy link
Contributor

Remove references to Cardboard in documentation

@@ -14,8 +14,8 @@ examples: []
The laser-controls component provides tracked controls with a laser or ray
cursor shooting out to be used for input and interactions. *DoF* stands for
[degrees of freedom][dof]. Because they only require rotation and some form of
input, laser-based interactions scale well across 0 DoF (gaze-based,
Cardboard), and 6 DoF (Vive, Oculus Touch). If desired, we can get a consistent form of interaction that works
input, laser-based interactions scale well across 0 DoF (gaze-based),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be some confusion why gaze-based is referred to as 0 DoF. With eye tracking it's common to use 'gaze' to mean a 3 DoF input, especially now Cardboard isn't mentioned any more.

This section could perhaps be reworded, I don't think the term DoF needs to be introduced at all. Perhaps something along the lines of:

The laser-controls component provides tracked controls with a laser or ray
cursor shooting out to be used for input and interactions. It only requires a way to orientate the laser and an input the user can trigger. This makes it usable on a wide range of devices. Using laser-controls we can get a consistent form of interaction that works across all VR platforms with a single line of HTML.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I used your paragraph.

@vincentfretin vincentfretin force-pushed the doc-remove-ref-Cardboard branch from e32a74b to 998c0b3 Compare January 23, 2025 10:21
@dmarcos
Copy link
Member

dmarcos commented Jan 23, 2025

Thanks!

@dmarcos dmarcos merged commit 05dccae into aframevr:master Jan 23, 2025
2 checks passed
@vincentfretin vincentfretin deleted the doc-remove-ref-Cardboard branch January 24, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants