fix SBS navigation - #384
Open
natebrennand wants to merge 2 commits into
Open
Conversation
agavra
reviewed
May 27, 2026
agavra
left a comment
agavra
left a comment
Owner
There was a problem hiding this comment.
LGTM, one thing that's probably worth making consistnetn across SBS and unified instead of accounting for it
| // blank line above, so no extra Spacing is needed here. | ||
| // File header: unified mode uses a 3-line box (border+name+border), | ||
| // side-by-side uses a single ═══ header line. | ||
| // The annotation count must match the renderer's visual line count. |
Owner
There was a problem hiding this comment.
ugh I totally forgot to test this change on the side-by-side mode. I think a better fix here is probably to render the headers the same way (e.g. a box for all of it).
Owner
There was a problem hiding this comment.
alternatively I'm happy going tback to just a single header line for unified as well. I don't know if I actually love the new boxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zz,zband expand diffs features were broken on main when using side-by-side diffs. This fixes all the issues I identified and adds some tests that should help mitigate future regressions 🤞🏻.