fix(ui): label whitespace leader keys as <space>/<tab> in help popup - #519
Open
R3l4x3 wants to merge 1 commit into
Open
fix(ui): label whitespace leader keys as <space>/<tab> in help popup#519R3l4x3 wants to merge 1 commit into
R3l4x3 wants to merge 1 commit into
Conversation
With `leader = " "` the help popup interpolated the raw character, so a chord like the file-list toggle rendered as a bare blank plus `e` and read as an unbound single key. Keys without a visible glyph now get a readable label: `<space>` for the space bar, `<tab>` for a tab leader. The key gutter padding was baked into each string literal and assumed a single-cell leader, so it moves into a helper that pads the column and keeps a separator space when a label overflows it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
leader = " "the help popup interpolated the raw character, so a chord like the file-list toggle rendered as a bare blank pluseand read as an unbound single key. Keys without a visible glyph now get a readable label:<space>for the space bar,<tab>for a tab leader.The key gutter padding was baked into each string literal and assumed a single-cell leader, so it moves into a helper that pads the column and keeps a separator space when a label overflows it.