fix: No colors/theme support when running tuicr remotely over SSH/Mosh in Gho... - #543
Open
yhay81 wants to merge 1 commit into
Open
fix: No colors/theme support when running tuicr remotely over SSH/Mosh in Gho...#543yhay81 wants to merge 1 commit into
yhay81 wants to merge 1 commit into
Conversation
benja2998
suggested changes
Aug 5, 2026
|
|
||
| // A themed TUI explicitly requires colors. Crossterm otherwise honors a | ||
| // remote NO_COLOR environment variable and suppresses every color command. | ||
| crossterm::style::force_color_output(true); |
There was a problem hiding this comment.
This will break tuicr on some less advanced terminals. Can't you just have the user set TERM/NO_COLOR/COLORTERM before launching tuicr instead of changing the tuicr code to forcefully display colors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #538.
Summary
No colors/theme support when running tuicr remotely over SSH/Mosh in Ghostty
Validation
🤖 AI-authored PR, operated by @yhay81.