fix(pr): skip linguist-generated files before highlighting - #604
Open
floze-the-genius wants to merge 1 commit into
Open
fix(pr): skip linguist-generated files before highlighting#604floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #588.
What changed
linguist-generatedthrough Git's attribute matcher when a PR has a matching local checkout.true, bare, false, and unspecified attribute values.This is intentionally narrower than #525: that PR adds optional post-load collapsing and review-progress behavior. The change here addresses the #588 stall specifically by preventing generated files from reaching syntax highlighting at all.
Verification
2files loaded instead of1) and passes after it; the retained Rust file still has highlighted spans.cargo checkcargo fmt --all --checkcargo clippy -- -D warningscargo test(1473 passed,0 failed,2 ignored)cargo run -- --no-update-checkagainst this branch's own six-file diff.AI assistance
Implemented and reviewed with OpenAI Codex. I verified the behavior, tests, full diff, and final commit locally.