security: clear high-severity alerts (svgo 4.0.2, sharp 0.35.x) - #18
Merged
Conversation
svgo -> 4.0.2 (GHSA-2p49-hgcm-8545: removeScripts leaves some executable scripts intact) via lockfile bump. sharp -> 0.35.x (GHSA-f88m-g3jw-g9cj: inherited libvips CVEs CVE-2026-33327/33328, vulnerable < 0.35.0). sharp is transitive via astro, which still declares ^0.34.0, so pin it with an npm override instead of forcing an astro major bump (audit wanted astro@7 — a breaking change for a transitive image-processing dep). Verified: npm install clean, astro build succeeds (4 pages), 0 high / 0 critical remaining in npm audit.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears both open high-severity Dependabot alerts on this repo.
svgoremoveScriptsplugin leaves some executable scripts intact< 4.0.2sharpWhy an override for sharp
sharpis transitive —astrodeclaressharp: ^0.34.0, so a plain lockfile bump can't cross into0.35.x.npm auditwanted to resolve this by moving astro 6.4 → 7.1.3, a major bump with real breaking-change surface, purely to satisfy a transitive image-processing dep.Instead this pins
sharpviaoverrides(the repo already uses that pattern foresbuild). Astro stays on 6.4.x, andsharplands on a patched libvips.sharp@0.35requires Node>=20.9.0— fine for this project.Verification
npm install— cleannpm run build(astro build) — succeeds, 4 pages built, no warnings from the overridenpm audit— 0 high / 0 critical remaining (1 moderate left: astro XSS advisories that need astro 7, tracked separately)Out of scope
The remaining open astro alerts (GHSA-f48w-9m4c-m7f5 medium, GHSA-4g3v-8h47-v7g6 medium, GHSA-7pw4-f3q4-r2p2 low) all require the astro 7 major. Worth doing deliberately as its own PR with a real smoke pass, not bundled into a security patch.