fix: remove debug logs and update stale DNS comments in agent-secret - #317
Merged
Haven Xia (HavenXia) merged 7 commits intoJul 23, 2026
Conversation
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/agent-secret-debug-cleanup
branch
2 times, most recently
from
July 14, 2026 19:00
37baa76 to
759d385
Compare
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/agent-secret-debug-cleanup
branch
from
July 16, 2026 06:43
759d385 to
b0a00ff
Compare
…g-cleanup # Conflicts: # demos/agent-secret/main.go
Contributor
Author
|
Haven Xia (@HavenXia) would you mind taking a look when you get a chance, since you touched this file recently? |
Haven Xia (HavenXia)
self-requested a review
July 17, 2026 17:46
Haven Xia (HavenXia)
approved these changes
Jul 22, 2026
Haven Xia (HavenXia)
left a comment
Haven Xia (HavenXia)
left a comment
Collaborator
There was a problem hiding this comment.
nit: The 2nd point in description says "Update stale substrate.k8s.io references to substrate.ate.dev in comments" but seems it has been cleared, please remove.
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.