api: add actor_uid to Assignment alongside actor - #736
Merged
Haven Xia (HavenXia) merged 3 commits intoAug 6, 2026
Merged
Conversation
Contributor
Author
Troy Chiu (troychiu)
force-pushed
the
fix-issue-653-actor-uid-assignment
branch
from
August 5, 2026 17:45
0637e50 to
e09dd6f
Compare
Haven Xia (HavenXia)
previously approved these changes
Aug 5, 2026
Collaborator
|
Change looks good. Some tests seem to be failing though. |
Troy Chiu (troychiu)
force-pushed
the
fix-issue-653-actor-uid-assignment
branch
from
August 5, 2026 23:38
e09dd6f to
31017b5
Compare
Contributor
Author
I took a look, and it doesn't appear to be related to this PR. #218 seems relevant. |
Contributor
Author
|
Just did a rebase onto main. |
Haven Xia (HavenXia)
approved these changes
Aug 5, 2026
Contributor
Author
|
Haven Xia (@HavenXia) thanks for the review. The failure went away. |
Contributor
Author
|
Hi Haven Xia (@HavenXia) , do you mind merging this one? Thank you. |
Collaborator
Sure! Sorry for the delay |
Contributor
Author
|
No worries and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #653 by adding
actor_uidtoAssignmentalongsideactor