Make UpdateActorSnapshot follow substrate API guidelines - #758
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoAug 6, 2026
Merged
Conversation
Luiz Oliveira (laoj2)
force-pushed
the
update-methods-snapshot
branch
2 times, most recently
from
August 5, 2026 16:20
1ad053d to
83b3c59
Compare
Luiz Oliveira (laoj2)
force-pushed
the
update-methods-snapshot
branch
from
August 6, 2026 01:23
83b3c59 to
a28e6e8
Compare
Luiz Oliveira (laoj2)
requested a review
from Julian Gutierrez Oschmann (juli4n)
August 6, 2026 01:28
Luiz Oliveira (laoj2)
marked this pull request as ready for review
August 6, 2026 01:28
| applyActorUpdateMask(actor, in, req.GetUpdateMask()) | ||
| applyUpdateMask(actor, in, req.GetUpdateMask(), actorMutableFields) | ||
|
|
||
| updated, err := s.persistence.UpdateActor(ctx, actor, expectedVersion) |
Collaborator
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 6, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 6, 2026
aa9b7b8
into
agent-substrate:main
13 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #732
UpdateActorSnapshotnow carries the resource itself +update_maskscopeis now applied via the update maskupdate_maskto a separate file, so it can be reused by other update RPCs.uidandversionas optional guards.