Make envtest offline-capable and factor out TestMain boilerplate - #792
Merged
Dmitry Berkovich (dberkov) merged 1 commit intoAug 7, 2026
Merged
Conversation
Haven Xia (HavenXia)
force-pushed
the
envtest-offline
branch
from
August 7, 2026 06:47
b7a122c to
f9a1bce
Compare
Haven Xia (HavenXia)
marked this pull request as ready for review
August 7, 2026 06:49
Haven Xia (HavenXia)
force-pushed
the
envtest-offline
branch
from
August 7, 2026 06:50
f9a1bce to
bcd4013
Compare
Dmitry Berkovich (dberkov)
merged commit Aug 7, 2026
3d33153
into
agent-substrate:main
11 checks passed
| shift | ||
|
|
||
| ROOT="$(git rev-parse --show-toplevel)" | ||
| ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" |
Collaborator
There was a problem hiding this comment.
Why this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-envtest usewith no version re-resolves "latest" against the remote release index on every run, so the envtest-backed packages needed network even with fully cached binaries.This PR pins the control plane to
1.36.x, and fold the three per-packageenvtestintointernal/testenv.Start, which also honors-short:go test -short ./...skips the envtest-backed packages and is the guaranteed-offline path.Have Claude to help me fix it
Fixes #789