Add ActorTemplate and ActorTemplateVersion as substrate resources - #822
Closed
Zoe Zhao (zoez7) wants to merge 1 commit into
Closed
Add ActorTemplate and ActorTemplateVersion as substrate resources#822Zoe Zhao (zoez7) wants to merge 1 commit into
Zoe Zhao (zoez7) wants to merge 1 commit into
Conversation
…ne proto
Introduce ActorTemplate (identity + placement policy) and
ActorTemplateVersion (immutable workload definition), along with the
supporting SandboxClass/SandboxConfig, SnapshotsConfig, ResumeSource,
and OnResumeConfig messages.
The version status State enum mirrors the existing ActorTemplateVersion
CRD PhaseType (RESUME_GOLDEN_ACTOR -> WAIT_GOLDEN_ACTOR ->
{READY | FAILED}, with UNSPECIFIED for the initial empty phase).
Zoe Zhao (zoez7)
requested review from
Haven Xia (HavenXia) and
Julian Gutierrez Oschmann (juli4n)
August 10, 2026 16:05
| ActorTemplateSpec spec = 2; | ||
| } | ||
|
|
||
| message ActorTemplateSpec { |
Collaborator
There was a problem hiding this comment.
As discussed offline ActorTemplateSpec will be flatten into ActorTemplate.
Collaborator
Author
|
I tried to stack PR reviews on top of each other, and failed. Closing this PR. Will use #824 to review these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #477 . Adding both AT and ATV as global resources in substrate.
All ATV fields are immutable. SandboxConifg will be frozen into ATV at creation time.
Not yet, will add documentation once we cut over from the the current CRD impl.
Demo: what the counter demo will look like with AT and ATV: