Update codex to 0.123.0 - #108
Closed
codex-acp-ci-app[bot] wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously broken areas were the typed fixtures used by
command-action-events.test.ts,load-session.test.ts, andterminal-output-events.test.ts. After the Codex update,dynamicToolCallrequires anamespacefield, so those fixtures no longer matched the regeneratedThreadItemtype and TypeScript rejected them. There was also a compile failure inCodexEventHandler.tsbecause the updatedServerNotificationunion addeditem/fileChange/patchUpdated, and the switch was no longer exhaustive.I changed the three test fixtures to set
namespace: nullon dynamic tool calls so they match the new app-server schema, and I added an explicititem/fileChange/patchUpdatedno-op case inCodexEventHandlerso the notification mapping stays exhaustive without hiding new variants behind a fallback. The reason for both changes was to align the codebase with the updated generated protocol types while preserving current runtime behavior.