Update codex to 0.124.0 - #119
Closed
acp-release-bot[bot] wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously broken post-update coverage was concentrated in
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts:prefetches session additional skill roots before thread startwas still mockingthreadStartwith an outdated response shape and a legacy sandbox value, so it no longer reflected the expandedThreadStartResponse.forwards failed MCP startup as failed tool call updates after new sessionwas using stale model-list fields likenameandhasMore, plus incomplete thread-start data, which no longer matched the regenerated app-server types.prefetches session additional skill roots before turn startwas bypassing the updatedTurnandTurnCompletedNotificationcontract with incomplete turn objects.I changed
src/__tests__/acp-test-utils.tsto add typed fixture builders forModel,Thread,ThreadStartResponse,Turn, andTurnCompletedNotification, then switched thoseCodexAcpClienttests over to the shared typed fixtures. The point was to remove theas anyescape hatches and stale mock payloads so future Codex schema drift is caught by the tests instead of being silently masked.