Skip to content

LLM-21851 change model encoding - #14

Merged
NikolaiSviridov merged 3 commits into
mainfrom
nikolaisv/LLM-21851-change-model-id
Jan 8, 2026
Merged

LLM-21851 change model encoding#14
NikolaiSviridov merged 3 commits into
mainfrom
nikolaisv/LLM-21851-change-model-id

Conversation

@NikolaiSviridov

@NikolaiSviridov NikolaiSviridov commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator

Changed model encoding from model/effort to model[effort]

some extra info/mock/video in PR for plugin

Comment thread src/__tests__/CodexACPAgent/data/auth-with-key.json Outdated
Comment thread src/__tests__/CodexACPAgent/data/auth-failed.json
Comment thread src/__tests__/CodexACPAgent/CodexAcpClient.test.ts Outdated
Comment thread src/CodexAcpClient.ts

private async fetchAvailableModels(): Promise<Model[]> {
const models: Model[] = [];
let cursor: string | null = null;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just models.map() instead?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment, sorry

Comment thread src/CodexAcpClient.ts Outdated
Comment thread src/CodexAcpClient.ts

private async fetchAvailableModels(): Promise<Model[]> {
const models: Model[] = [];
let cursor: string | null = null;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong comment, sorry

@NikolaiSviridov NikolaiSviridov changed the title LLM-21851 change model encoding, add default model LLM-21851 change model encoding Jan 7, 2026
@NikolaiSviridov
NikolaiSviridov force-pushed the nikolaisv/LLM-21851-change-model-id branch from 0c6fcee to 3ecd5ff Compare January 7, 2026 16:06
@NikolaiSviridov
NikolaiSviridov merged commit d9a254e into main Jan 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants