Support ACP audio prompts - #339
Open
shreyas-shinde wants to merge 1 commit into
Open
Conversation
Author
|
Maintainer action needed: this PR is mergeable, but its GitHub Actions run is still blocked as action_required because the workflow has not been approved for this fork. Could a maintainer approve the run and review the ACP audio-content pass-through change? The implementation preserves negotiated capabilities and only forwards audio when the selected runtime advertises audio support; unsupported audio is rejected explicitly rather than silently dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The adapter currently returns
nullfor every ACP audio block, silently removing user input. Codex App Server already acceptsUserInput::Audiodata URLs, and model metadata exposes whether audio input is supported. This change preserves supported audio end to end while preventing unsupported models from replacing it with an omission placeholder.Verification
npm run typechecknpm run buildend_turn