Skip to content

Anna.zhdan/protcol update#88

Merged
anna239 merged 4 commits intomasterfrom
anna.zhdan/protcol-update
Mar 30, 2026
Merged

Anna.zhdan/protcol update#88
anna239 merged 4 commits intomasterfrom
anna.zhdan/protcol-update

Conversation

@anna239
Copy link
Copy Markdown
Contributor

@anna239 anna239 commented Mar 29, 2026

  • session/close
  • additionalDirectories
  • nes

@anna239 anna239 requested a review from nerzhulart March 29, 2026 18:49
@anna239 anna239 merged commit b30416e into master Mar 30, 2026
1 check passed
@egor-baranov
Copy link
Copy Markdown

The RFD for additional directories also explicitly extends session/list by adding ListSessionsRequest.additionalDirectories and defines exact-match filtering against the authoritative ordered additional-root list returned in SessionInfo.additionalDirectories.

In the current implementation, additionalDirectories was added to lifecycle requests and SessionInfo, but ListSessionsRequest, Client.listSessions(), and AgentSupport.listSessions() are still cwd-only. That means the SDK cannot express the required session/list filter and cannot fully support the recovery flow described in the RFD for preserving/reconstructing additional roots across load/resume.

That's not critical for overall additionalDirectories functionality, just required for consistency with RFD and better session observability.

@anna239
Copy link
Copy Markdown
Contributor Author

anna239 commented Mar 31, 2026

@egor-baranov thank you for noticing, fix is here #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants