Skip to content

fix: add dependency highlights in function callback scrollToHighlight… #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: add dependency highlights in function callback scrollToHighlight… #301

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1b0f813
fix: add dependency highlights in function callback scrollToHighlight…
Dec 16, 2024
1da8354
fix: add dependency highlights in function callback scrollToHighlight…
Dec 16, 2024
87b5aed
Merge remote-tracking branch 'originThai/fix/scroll_to_highlight' int…
Dec 16, 2024
9d91185
Merge remote-tracking branch 'originThai/fix/scroll_to_highlight' int…
Dec 16, 2024
3823dab
Merge remote-tracking branch 'originThai/fix/scroll_to_highlight' int…
Dec 16, 2024
171b564
Merge remote-tracking branch 'originThai/fix/scroll_to_highlight' int…
Dec 16, 2024
5fc6c88
Merge remote-tracking branch 'originThai/fix/scroll_to_highlight' int…
Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ export function App() {
const scrollViewerTo = useRef((highlight: IHighlight) => {});

const scrollToHighlightFromHash = useCallback(() => {
const highlight = getHighlightById(parseIdFromHash());
const highlight = getHighlightById(parseIdFromHash(), highlights);
if (highlight) {
scrollViewerTo.current(highlight);
}
}, []);
}, [highlights]);

useEffect(() => {
window.addEventListener("hashchange", scrollToHighlightFromHash, false);
Expand All @@ -87,7 +87,7 @@ export function App() {
};
}, [scrollToHighlightFromHash]);

const getHighlightById = (id: string) => {
const getHighlightById = (id: string, highlights: Array<IHighlight>) => {
return highlights.find((highlight) => highlight.id === id);
};

Expand Down
Loading