fix: enable DI for FeatureOptInService#13
Open
tomerqodo wants to merge 2 commits into
Open
Conversation
🤖 Augment PR SummarySummary: This PR enables dependency injection (DI) for the feature opt-in stack and standardizes how the feature flags repository is wired. Changes:
Technical Notes: Uses 🤖 Was this summary useful? React with 👍 or 👎 |
| }); | ||
|
|
||
| export const moduleLoader: ModuleLoader = { | ||
| token: moduleToken, |
There was a problem hiding this comment.
moduleLoader.token is set to moduleToken, but bindModuleToClassOnToken consumers use dep.token as the injectable token, and container.get() here also uses moduleLoader.token. This will try to resolve FEATURES_REPOSITORY_MODULE (which is only a load key) instead of the bound FEATURES_REPOSITORY token, causing runtime DI resolution failures.
Other Locations
packages/features/di/containers/FeaturesRepository.ts:7packages/features/di/modules/FeatureOptInService.ts:16packages/features/bookings/di/RegularBookingService.module.ts:32packages/features/booking-audit/di/BookingAuditTaskConsumer.module.ts:22
🤖 Was this useful? React with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#13