refactor: Remove trpc/react dependency from @calcom/atoms#12
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1926c8e066
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {teamMembers.map((member) => ( | ||
| <TeamMemberItem key={member.value} member={member} onWeightChange={handleWeightChange} /> | ||
| ))} | ||
| {filteredMembers.length === 0 && ( | ||
| {teamMembers.length === 0 && ( | ||
| <div className="text-subtle py-4 text-center text-sm">{t("no_members_found")}</div> |
There was a problem hiding this comment.
The component still computes filteredMembers (including searchQuery and assignAllTeamMembers filtering), but the render now maps over teamMembers directly. This makes the search box and the "assign all team members" filtering ineffective, and the "no_members_found" empty state can never appear for a non-empty team. This is a regression in the edit-weights UI when users search or when only a subset should be shown.
Useful? React with 👍 / 👎.
2 participants
Benchmark PR from agentic-review-benchmarks#12