fix(api): return original email without OAuth suffix in bookings - #4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6968d6a13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return this.getOutputRecurringSeatedBooking(databaseBooking, showAttendees); | ||
| }); | ||
|
|
||
| return transformed.sort((a, b) => new Date(a.start).getTime() - new Date(b.start).getTime()); | ||
| return transformed; |
There was a problem hiding this comment.
In getOutputRecurringSeatedBookings you now return the mapped array unsorted. The IDs passed in are sourced from bookings.repository.ts#getRecurringByUidWithAttendeesAndUserAndEvent, which uses Prisma findMany without orderBy, so the DB return order is not guaranteed. That means GET /v2/bookings/{bookingUid} for a recurring seated booking can now return bookings in arbitrary order between calls, whereas it previously sorted by start. Consider restoring the start sort here or adding orderBy in the repository to keep a stable chronological response.
Useful? React with 👍 / 👎.
1 participant
Benchmark PR from agentic-review-benchmarks#4