feat: limit badges to 2 with hover/click popover in UserListTable - #8
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b8cbd51ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {hiddenItems.map((item, index) => ( | ||
| <span | ||
| key={item.label} | ||
| className="text-default cursor-pointer text-sm hover:text-emphasis"> | ||
| {item.label} |
There was a problem hiding this comment.
Hidden items in LimitedBadges are rendered as plain <span> elements without using item.onClick, even though BadgeItem supports it. In UserListTable, each team badge supplies an onClick to filter by that team; when a user belongs to more than two teams, the extra teams move into the popover and become non-clickable. This is a functional regression for any caller expecting click behavior on hidden items. Consider invoking item.onClick (and using a button/Badge) for hidden entries so filtering still works when there are more than maxVisible items.
Useful? React with 👍 / 👎.
1 participant
Benchmark PR from agentic-review-benchmarks#8