feat: update recording, transcript endpoint and add tests #16
Conversation
| @UseGuards(BookingUidGuard) | ||
| // @UseGuards(ApiAuthGuard, BookingUidGuard, BookingPbacGuard) | ||
| @Pbac(["booking.readRecordings"]) | ||
| @Permissions([BOOKING_WRITE]) |
There was a problem hiding this comment.
Bug: The getBookingRecordings GET endpoint incorrectly requires BOOKING_WRITE permission instead of BOOKING_READ, which is inconsistent with its read-only function and other similar endpoints.
Severity: MEDIUM
Suggested Fix
Change the @Permissions decorator for the getBookingRecordings endpoint from [BOOKING_WRITE] to [BOOKING_READ]. This aligns the permission with the endpoint's read-only functionality and makes it consistent with other GET endpoints in the controller.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: apps/api/v2/src/ee/bookings/2024-08-13/controllers/bookings.controller.ts#L216
Potential issue: The `getBookingRecordings` endpoint, a GET request for fetching data,
incorrectly requires `BOOKING_WRITE` permission. This contradicts its read-only nature,
the associated `@Pbac(["booking.readRecordings"])` decorator which implies a read
operation, and other similar GET endpoints in the same controller that use
`BOOKING_READ`. This will cause permission failures for users who have read access but
not write access to bookings, preventing them from viewing recordings they should be
able to access, violating the principle of least privilege.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#16