fix(api): defer streaming response until referenced variables are updated#1
Conversation
🤖 Augment PR SummarySummary: This PR fixes streaming responses that reference conversation variables by ensuring output streaming is deferred until the relevant variable assignment has completed. Changes:
Technical Notes: The response coordinator builds a 🤖 Was this summary useful? React with 👍 or 👎 |
| Returns True if this node updates any of the requested conversation variables. | ||
| """ | ||
| assigned_selector = self.node_data.assigned_variable_selector | ||
| return assigned_selector in variable_selectors |
There was a problem hiding this comment.
variable_selectors is built as a set[tuple[str, ...]] (see response coordinator), but assigned_variable_selector is a Sequence[str] (likely a list), so assigned_selector in variable_selectors will never match and this node won’t actually block streaming. Consider normalizing to a tuple (similar to v2.VariableAssignerNode.blocks_variable_output) before the membership check.
🤖 Was this useful? React with 👍 or 👎
Benchmark PR from agentic-review-benchmarks#1