Skip to content

fix(web): enable JSON_OBJECT type support in console UI#2

Open
tomerqodo wants to merge 5 commits into
augment_full_base_fixweb_enable_json_object_type_support_in_console_ui_pr2from
augment_full_head_fixweb_enable_json_object_type_support_in_console_ui_pr2
Open

fix(web): enable JSON_OBJECT type support in console UI#2
tomerqodo wants to merge 5 commits into
augment_full_base_fixweb_enable_json_object_type_support_in_console_ui_pr2from
augment_full_head_fixweb_enable_json_object_type_support_in_console_ui_pr2

Conversation

@tomerqodo

Copy link
Copy Markdown

Benchmark PR from agentic-review-benchmarks#2

@augmentcode

augmentcode Bot commented Jan 26, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Enables JSON_OBJECT input variable support in the web console configuration modal.

Changes:

  • Update the JSON schema placeholder to a full object schema (root type: "object" with properties)
  • Expose the json_object input type option for non-basic apps (removes the previous support gate)
  • Persist/display the entire JSON schema (not just properties) with pretty-printed formatting
  • Normalize empty json_schema to undefined when saving
  • Validate schema JSON parsing and enforce root schema type is object
  • Add i18n strings for new JSON schema validation error messages

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

}
handlePayloadChange('json_schema')(JSON.stringify(res, null, 2))
handlePayloadChange('json_schema')(value)
return True

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return True will throw/ fail TypeScript (True is not defined in JS/TS), and CodeEditor ignores the callback return value anyway. This should likely be true (lowercase) or removed entirely to avoid breaking JSON schema editing.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants