feat(ui-v2): add WorkPoolEditForm component for editing work pools

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#13

Summary by CodeRabbit

Release Notes

• New Features
  • Added work pool editing interface allowing users to modify description and concurrency limit fields.
  • Integrated form validation with real-time feedback through toast notifications for success and error states.
  • Automatic navigation to work pool details page following successful updates.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces a new work pool edit form feature, including a React component for editing work pools, supporting API hooks and types, comprehensive test coverage, Storybook stories, and updates the routing to render the new edit interface.

Changes

Cohort / File(s)	Summary
API Exports ui-v2/src/api/work-pools/index.ts	Adds exports for useUpdateWorkPool hook and WorkPoolUpdate type to support the edit functionality.
Edit Component & Public Exports ui-v2/src/components/work-pools/edit/index.ts	Adds exports for WorkPoolEditForm component and WorkPoolEditFormValues / workPoolEditSchema from schema module.
Edit Form Component ui-v2/src/components/work-pools/edit/work-pool-edit-form.tsx	Introduces new React component that renders an editable form with read-only name/type fields and editable description/concurrency fields, handling validation, submission, and navigation via hooks.
Edit Form Tests ui-v2/src/components/work-pools/edit/work-pool-edit-form.test.tsx	Comprehensive test suite covering form rendering, field editing, submission flow, error/success handling, navigation, and variant rendering with mocked router and API hooks.
Edit Form Stories ui-v2/src/components/work-pools/edit/work-pool-edit-form.stories.tsx	Storybook stories file with multiple test scenarios (default, null values, different work pool types, success/error responses) and MSW handlers for API mocking.
Route Handler ui-v2/src/routes/work-pools/work-pool_.$workPoolName.edit.tsx	Updates the edit route to render WorkPoolEditPageHeader and WorkPoolEditForm components instead of static text placeholder.

Sequence Diagram

sequenceDiagram
    participant User
    participant Form as WorkPoolEditForm
    participant Router as Router
    participant Hook as useUpdateWorkPool
    participant API as API
    participant Toast as Toast System

    User->>Form: Edit fields & Submit
    Form->>Hook: Call updateWorkPool(payload)
    Hook->>API: PATCH /api/work_pools/:name
    
    alt Success (204)
        API-->>Hook: Success response
        Hook-->>Form: Success callback
        Form->>Toast: Show success message
        Form->>Router: Navigate to detail page
        Router-->>User: Redirect
    else Error
        API-->>Hook: Error response
        Hook-->>Form: Error callback
        Form->>Toast: Show error message
        Form-->>User: Display error to user
    end
    
    User->>Form: Click Cancel
    Form->>Router: Navigate back
    Router-->>User: Return to previous page

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A new form blooms where work pools play,
With editable fields to brighten the day,
Tests and stories ensure all is right,
While toasts celebrate each save's flight! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is minimal and incomplete. While it references a benchmark PR, it lacks required sections from the template such as overview of changes, issue references, test coverage confirmation, and checklist completion.	Add a proper overview of the proposed changes, confirm test coverage with the new test file, reference any related issues, and complete the checklist items.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a WorkPoolEditForm component for editing work pools, which aligns with all file modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch coderabbit_full_head_featui-v2_add_workpooleditform_component_for_editing_work_pools_pr13

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tomerqodo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[tomerqodo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[tomerqodo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[bar-qodo]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.