Add block document reference support to schema form#4
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18b14dce7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <BlockDocumentCreateForm | ||
| blockTypeId={blockType.id} | ||
| blockSchemaId={blockSchema.id} | ||
| blockSchemaFields={blockSchema.fields as unknown as PrefectSchemaObject} | ||
| onCreated={onCreated} |
There was a problem hiding this comment.
as unknown cast in schema fields
ui-v2/src/components/AGENTS.md explicitly says “NEVER use as unknown”; the cast blockSchema.fields as unknown as PrefectSchemaObject violates this rule and bypasses type safety. Please replace it with a safe conversion or a type guard so the schema is validated without unsafe casting.
Useful? React with 👍 / 👎.
| const filteredData = useMemo(() => { | ||
| return data.filter((blockDocument) => | ||
| blockDocument.name?.toLowerCase().includes(deferredSearch.toLowerCase()), | ||
| ); |
There was a problem hiding this comment.
AGENTS.md (repo root) requires tab indentation for TypeScript in ui-v2, but this block is indented with spaces. Please reindent this section with tabs to comply with the formatting rule.
Useful? React with 👍 / 👎.
| const onSave = async (zodFormValues: BlockNameFormSchema) => { | ||
| try { | ||
| await validateForm({ schema: values }); | ||
| if (errors.length > 0) { | ||
| return; |
There was a problem hiding this comment.
After await validateForm(...), errors is still the pre-validation state because validateForm only schedules a React state update. That means createBlockDocument can run even when validation fails (e.g., required schema fields missing), or can be blocked even after errors are cleared. Consider returning a validation result from validateForm and branching on that instead of the stale errors array.
Useful? React with 👍 / 👎.
1 participant
Benchmark PR from agentic-review-benchmarks#4