Code Review Bench PR #19997 - feat(ui-v2): Add trigger form templates#10
Open
tomerqodo wants to merge 3 commits into
Open
Code Review Bench PR #19997 - feat(ui-v2): Add trigger form templates#10tomerqodo wants to merge 3 commits into
tomerqodo wants to merge 3 commits into
Conversation
…ool-status, work-queue-status, and custom triggers - Create DeploymentStatusTriggerFields component with status select - Create WorkPoolStatusTriggerFields component with status select - Create WorkQueueStatusTriggerFields component with status select - Create CustomTriggerFields component with textarea for expected events - Update TriggerStep to use new components instead of placeholders - Export all new components from index.ts All components follow the same pattern as FlowRunStateTriggerFields with: - PostureSelect for Reactive/Proactive toggle - Threshold input field - Conditional Within field (shown only for Proactive posture) Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
…mponents Update tests to check for actual component rendering instead of placeholder text now that the trigger form templates are implemented. Co-Authored-By: alex.s@prefect.io <ajstreed1@gmail.com>
This was referenced Jan 26, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bench PR PrefectHQ#19997
Original PR Title: feat(ui-v2): Add trigger form templates
Original PR Description: Implements Phase 4 of the trigger form templates for the automations wizard, replacing placeholder "coming soon" messages with functional form components for the remaining 4 trigger types.
Changes
This PR adds 4 new trigger field components that follow the same pattern as the existing
FlowRunStateTriggerFields:All components include:
Screenshot
Review Focus
prefect.deployment.ready) match backend expectationscloses OSS-7417
Checklist
<link to issue>"mint.json.Link to Devin run: https://app.devin.ai/sessions/5c547ac1154646648315fefae73b003f
Requested by: alex.s@prefect.io (@desertaxle)
Original PR URL: PrefectHQ#19997