Skip to content

fix: a few regressions from previous PRs#10

Open
tomerqodo wants to merge 5 commits into
coderabbit_full_base_fix_a_few_regressions_from_previous_prs_pr10from
coderabbit_full_head_fix_a_few_regressions_from_previous_prs_pr10
Open

fix: a few regressions from previous PRs#10
tomerqodo wants to merge 5 commits into
coderabbit_full_base_fix_a_few_regressions_from_previous_prs_pr10from
coderabbit_full_head_fix_a_few_regressions_from_previous_prs_pr10

Conversation

@tomerqodo

@tomerqodo tomerqodo commented Jan 30, 2026

Copy link
Copy Markdown

Benchmark PR from agentic-review-benchmarks#10

Summary by CodeRabbit

  • Breaking Changes

    • Renamed with_window_features() to window_features() in WebviewBuilder API
    • Cookie type now re-exported from tauri_runtime instead of external dependency
  • Bug Fixes

    • Fixed cookie deletion behavior to properly handle cookie operations
  • Behavior Changes

    • Updated window feature application order (size processed before position)

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 30, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

These changes update Tauri's window builder API and cookie handling mechanisms. A builder method is renamed from with_window_features to window_features and its application order is adjusted. Additionally, the cookie delete operation's internal implementation is modified, and tauri_runtime::Cookie is re-exported in the public API.

Changes

Cohort / File(s) Summary
Window Builder API Refactoring
crates/tauri/src/webview/mod.rs, crates/tauri/src/webview/webview_window.rs, examples/api/src-tauri/src/lib.rs
Renamed public builder method from with_window_features() to window_features(). Adjusted NewWindowFeatures application order to process inner_size before position. Updates propagate through builder chains in example code.
Cookie Runtime Implementation
crates/tauri-runtime-wry/src/lib.rs
Modified delete_cookie internal behavior to send WebviewMessage::SetCookie instead of WebviewMessage::DeleteCookie.
Public API Export
crates/tauri/src/webview/mod.rs
Added public re-export of tauri_runtime::Cookie, replacing direct cookie crate dependency exposure in the public surface.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Builder methods shuffle, from \with_\\ to bare,
Window features reordered with algorithmic care,
Cookies change their message in the runtime's deep embrace,
APIs dance and realign across the codebase space! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: a few regressions from previous PRs' accurately reflects the changeset which contains multiple bug fixes and method renames addressing issues from prior changes across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch coderabbit_full_head_fix_a_few_regressions_from_previous_prs_pr10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants