Add coverage for Error, SignalEmitter, and SensorDispatchBridge#16
Merged
mikehostetler merged 3 commits intomainfrom Apr 1, 2026
Merged
Add coverage for Error, SignalEmitter, and SensorDispatchBridge#16mikehostetler merged 3 commits intomainfrom
mikehostetler merged 3 commits intomainfrom
Conversation
…or modules Add comprehensive test coverage for three modules that previously had no tests: - SensorDispatchBridge: Tests for forward/2, forward_many/2, and forward_or_ignore/2 including success cases, error handling for dead runtimes, invalid signals, and batch forwarding with error tracking. - SignalEmitter: Tests for dispatch configuration validation, signal emission with various formats, notification handling, and default signal type/source generation from resource names. - Error: Tests for all Ash error type conversions (Invalid, Forbidden, Framework, Unknown), underlying error extraction, field error mapping, and changeset error extraction. These tests improve overall test coverage and provide safety for future refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AshJido.Errorhelpers so modernAsh.Error.Changes.*errors are surfaced correctlyValidation
Supersedes #10.