[codex] Fix pod plugin alias expansion and add regression test#240
Closed
mikehostetler wants to merge 1 commit intomainfrom
Closed
[codex] Fix pod plugin alias expansion and add regression test#240mikehostetler wants to merge 1 commit intomainfrom
mikehostetler wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Meant to attach this to #239 - closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:pluginsinJido.Pod.__using__/1viaDefinition.expand_and_eval_literal_option/2beforeMacro.escape/1pod_plugins ++ (user_plugins || []))plugins:and verifies the module is resolved and mountedRoot Cause
Jido.Pod.__using__/1passedopts[:plugins]through raw. When the pod options were later escaped, aliased plugin modules remained as alias AST tuples rather than resolved module atoms, causing plugin normalization/compile checks to fail.Impact
Pods can now safely use aliased plugin modules in
plugins:declarations. This restores expected macro behavior and prevents compile-time plugin extraction failures.Validation
mix test test/jido/pod_test.exs test/jido/pod/topology_test.exs test/jido/pod/mutation/planner_test.exs test/jido/pod/mutation_runtime_test.exs test/jido/pod/runtime_test.exs test/jido/pod/telemetry_test.exs