Fix missing log_level propagation in Turn.execute_internal/6#241
Open
bwittenbrook3 wants to merge 1 commit intoagentjido:mainfrom
Open
Fix missing log_level propagation in Turn.execute_internal/6#241bwittenbrook3 wants to merge 1 commit intoagentjido:mainfrom
bwittenbrook3 wants to merge 1 commit intoagentjido:mainfrom
Conversation
Jido.Exec.run/4 defaults its log_level threshold to :info when none is provided in opts, causing :notice-level "Executing ..." lines to fire on every tool call from the LLM turn loop. The agent strategy path correctly injects log_level via Jido.Observe.Config.action_exec_opts/2, but the jido_ai Turn module called Jido.Exec.run directly with bare exec_opts, bypassing that config entirely. Fix: inject log_level from Jido.Observe.Config.action_log_level/0 in execute_internal/6 via Keyword.put_new/3, so explicit caller opts still take precedence while the global :jido, :telemetry config is respected for all tool executions. Add unit tests verifying: - Explicit log_level: :warning suppresses Executing logs via execute_module/4 - Explicit log_level: :warning suppresses Executing logs via execute/4 - Explicit log_level: :warning suppresses logs via run_tools/3 - Global :jido telemetry config is respected when no explicit opt given - Explicit opt takes precedence over global config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jido.Exec.run/4 defaults its log_level threshold to :info when none is provided in opts, causing :notice-level "Executing ..." lines to fire on every tool call from the LLM turn loop. The agent strategy path correctly injects log_level via Jido.Observe.Config.action_exec_opts/2, but the jido_ai Turn module called Jido.Exec.run directly with bare exec_opts, bypassing that config entirely.
Fix: inject log_level from Jido.Observe.Config.action_log_level/0 in execute_internal/6 via Keyword.put_new/3, so explicit caller opts still take precedence while the global :jido, :telemetry config is respected for all tool executions.
Add unit tests verifying: