Skip to content

refactor(logging): localize ai observability logging with direct Logger#244

Open
nshkrdotcom wants to merge 4 commits intoagentjido:mainfrom
nshkrdotcom:logger-refactor-cleanup
Open

refactor(logging): localize ai observability logging with direct Logger#244
nshkrdotcom wants to merge 4 commits intoagentjido:mainfrom
nshkrdotcom:logger-refactor-cleanup

Conversation

@nshkrdotcom
Copy link
Copy Markdown
Contributor

Summary

  • rework the logging cleanup onto Mike Hostetler's requested shape for jido_ai
  • remove the repo-local logging facade pattern and use base Logger directly
  • keep redaction, safe previewing, and telemetry shaping local to the AI observability boundary
  • preserve compatibility-first defaults while keeping the deferred upstream jido_action dependency explicit

Supersedes

Mike-Requested Rework

  • remove the helper logging abstraction pattern
  • use direct Logger calls
  • keep lazy evaluation only where it materially matters
  • keep redaction/safe-inspect/telemetry shaping local to the AI/observability boundary
  • preserve compatibility by default

What This PR Keeps

  • quieter and cheaper logging on AI/tool execution hot paths
  • safer telemetry shaping for error/tool-result payloads
  • the compatibility-first stance around unreleased jido_action granular error behavior

Additional Work

Implementation

  • hardens tool execution timeout handling to use explicit child monitoring/result delivery instead of Task.yield/Task.shutdown
  • applies the same explicit timeout-monitor pattern in callback validation paths
  • includes a small compatibility/analyzer cleanup in graph traversal bookkeeping (MapSet to plain key map)

Tests

  • expands observability and signal-helper coverage around sanitized previews and action-error normalization

Impact

  • the logging/telemetry shape now follows the direct-Logger boundary-local design requested in review
  • timeout handling in tool execution and validation should be more predictable under cancellation and slow-runner conditions
  • the branch still does not force unreleased upstream jido_action granular behavior as a default dependency assumption

Risks

  • higher review surface than the other three replacement PRs because this branch includes timeout-path cleanup in addition to the logging rework
  • the main risk area is tool/validation timeout handling under supervised child-process shutdown, though the changes remain internal and non-breaking at the public API boundary

Testing

  • mix test
  • mix q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant