Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore memory #1975

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jeffbryner
Copy link

Description

Adds firestore memory to solve #1974


Type of change

  • [ x] New feature (non-breaking change which adds functionality)

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

firestore works best without having to create indexes. The data model collection_name/user_id/memories allows for selecting all memories and using an orderby without having to create a composite index which is a bit tricky in firestore (requires async calls, no callback when completed, not ready immediately).

@jeffbryner jeffbryner requested a review from a team as a code owner February 1, 2025 19:09
@manthanguptaa
Copy link
Contributor

Can you please add a corresponding cookbook and add the steps to setup firestore and get the required env variables at the top of the cookbook?

@jeffbryner
Copy link
Author

Hi @manthanguptaa I've added the cookbook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants