fix: address issue #4589 — Promote RollingUpdateFix Feature Gate from Beta to Stable#4597
Open
santoshguru-11 wants to merge 10 commits into
Conversation
RollingUpdateFix has been enabled by default since 1.50.0 and is stable enough to graduate. Changes: - pkg/util/runtime/features.go: move FeatureRollingUpdateFix to Stable section - install/helm/agones/defaultfeaturegates.yaml: move to Stable section - build/Makefile: remove from BETA_FEATURE_GATES - cloudbuild.yaml: remove RollingUpdateFix=false from inverted e2e config - site/content/en/docs/Guides/feature-stages.md: move row to Stable table - test/upgrade/versionMap.yaml: add stableGates entry for Dev version Closes agones-dev#4589
lacroixthomas
requested changes
Jun 1, 2026
Collaborator
lacroixthomas
left a comment
lacroixthomas
left a comment
There was a problem hiding this comment.
There is also some code to update as this will be stable: https://github.com/agones-dev/agones/blob/main/pkg/fleets/controller.go#L598
This part of the code was only used when the feature gate was enabled runtime.FeatureEnabled(runtime.FeatureRollingUpdateFix) but as it will be stable, we can just use it directly and cleanup the unused code from it
| "alphaGates": ["PlayerAllocationFilter", "PlayerTracking", "WasmAutoscaler"], | ||
| "betaGates": ["CountsAndLists", "GKEAutopilotExtendedDurationPods", "PortPolicyNone", "PortRanges", "RollingUpdateFix", "ScheduledAutoscaler", "FleetAutoscaleRequestMetaData", "SidecarContainers"] | ||
| "betaGates": ["CountsAndLists", "GKEAutopilotExtendedDurationPods", "PortPolicyNone", "PortRanges", "ScheduledAutoscaler", "FleetAutoscaleRequestMetaData", "SidecarContainers"], | ||
| "stableGates": ["RollingUpdateFix"] |
Collaborator
There was a problem hiding this comment.
There is no "stableGates", you can remove this line
Comment on lines
39
to
+56
|
|
||
| | Feature Name | Gate | Default | Stage | Since | | ||
| |------------------------------------------------------------------------------------------------------------------------|------------------------------------|---------|--------|--------| | ||
| | [CountsAndLists](https://github.com/agones-dev/agones/issues/2716) | `CountsAndLists` | Enabled | `Beta` | 1.41.0 | | ||
| | [Support for Extended Duration Pods on GKE Autopilot (*1.28+ only*)](https://github.com/agones-dev/agones/issues/3386) | `GKEAutopilotExtendedDurationPods` | Enabled | `Beta` | 1.44.0 | | ||
| | [Port Policy None](https://github.com/agones-dev/agones/issues/3804) | `PortPolicyNone` | Enabled | `Beta` | 1.49.0 | | ||
| | [Multiple dynamic port ranges](https://github.com/agones-dev/agones/issues/1911) | `PortRanges` | Enabled | `Beta` | 1.49.0 | | ||
| | [Rolling Update Fixes](https://github.com/agones-dev/agones/issues/3688) | `RollingUpdateFix` | Enabled | `Beta` | 1.50.0 | | ||
| | [Scheduled Fleet Autoscaling](https://github.com/agones-dev/agones/issues/3008) | `ScheduledAutoscaler` | Enabled | `Beta` | 1.51.0 | | ||
| | [Extend Webhook autoscaler to send fleet metadata with the request](https://github.com/agones-dev/agones/issues/3951) | `FleetAutoscaleRequestMetaData` | Enabled | `Beta` | 1.54.0 | | ||
| | [Sidecar Containers](https://github.com/agones-dev/agones/issues/3642) | `SidecarContainers` | Enabled | `Beta` | 1.56.0 | | ||
|
|
||
| ### Stable Features | ||
|
|
||
| | Feature Name | Gate | Default | Stage | Since | | ||
| |------------------------------------------------------------------------------------------|----------------------------|---------|----------|--------| | ||
| | [DisableResyncOnSDKServer](https://github.com/agones-dev/agones/issues/3377) | `DisableResyncOnSDKServer` | Enabled | `Stable` | 1.49.0 | | ||
| | [Support Passthrough on GKE Autopilot](https://github.com/agones-dev/agones/issues/3721) | `AutopilotPassthroughPort` | Enabled | `Stable` | 1.54.0 | | ||
| | [Rolling Update Fixes](https://github.com/agones-dev/agones/issues/3688) | `RollingUpdateFix` | Enabled | `Stable` | 1.50.0 | |
Collaborator
There was a problem hiding this comment.
You will need to add shortcodes around it, as it will only be the case from a specific version
https://agones.dev/site/docs/contribute/documentation-editing-contribution/#within-a-page
We usually copy the whole table and wrap them with shortcodes (< 1.58.0 and > 1.58.0 for example)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4589: Promote
RollingUpdateFixFeature Gate from Beta to Stable