chore: promote PortPolicyNone feature gate from Beta to Stable#4602
Open
Cloud-Architect-Emma wants to merge 1 commit into
Open
chore: promote PortPolicyNone feature gate from Beta to Stable#4602Cloud-Architect-Emma wants to merge 1 commit into
Cloud-Architect-Emma wants to merge 1 commit into
Conversation
- Move FeaturePortPolicyNone from Beta to Stable in features.go - Remove FeaturePortPolicyNone guards from gameserver.go and gke.go - Remove feature-gate-disabled test cases from unit tests - Remove t.Skip guard from e2e TestGameServerPortPolicyNone - Move PortPolicyNone to Stable section in defaultfeaturegates.yaml - Remove PortPolicyNone from BETA_FEATURE_GATES in Makefile - Remove PortPolicyNone=false from inverted e2e config in cloudbuild.yaml - Move row to Stable table in feature-stages.md - Add stable entry in versionMap.yaml for 1.59.0 Co-authored-by: Cloud-Architect-Emma <Cloud-Architect-Emma@users.noreply.github.com> Signed-off-by: Cloud-Architect-Emma <emmanuela_prince@yahoo.com>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Author
|
Hi @markmandel, the size warning is expected here as this touches all the required files for a feature gate promotion (12 files). All changes are part of the single task described in #4587, no unrelated changes included. Happy to split if preferred, but given the nature of a feature gate promotion the changes are tightly coupled. Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4587
Promotes the PortPolicyNone feature gate from Beta to Stable.
Changes:
pkg/util/runtime/features.go: Move FeaturePortPolicyNone from Beta to Stable section
pkg/apis/agones/v1/gameserver.go: Remove FeaturePortPolicyNone guards; fold logic unconditionally
pkg/cloudproduct/gke/gke.go: Remove FeaturePortPolicyNone check
pkg/apis/agones/v1/gameserver_test.go : Remove feature-gate-disabled test case and ParseFeatures call
pkg/cloudproduct/gke/gke_test.go : Remove portPolicyNoneFlag field, disabled test case and feature gate block
pkg/gameservers/gameservers_test.go : Remove ParseFeatures call
test/e2e/gameserver_test.go : Remove t.SkipNow guard from TestGameServerPortPolicyNone
install/helm/agones/defaultfeaturegates.yaml : Move PortPolicyNone to Stable section
build/Makefile : Remove PortPolicyNone from BETA_FEATURE_GATES
cloudbuild.yaml : Remove PortPolicyNone=false from inverted e2e config
site/content/en/docs/Guides/feature-stages.md : Move row to Stable table
test/upgrade/versionMap.yaml : Add stableGates entry for 1.59.0