Skip to content

Conversation

@Saizan
Copy link

@Saizan Saizan commented Aug 21, 2023

Here's a fix for issue 15, just changing the type of the field and the To/FromJSON instances.

@agrafix
Copy link
Owner

agrafix commented Oct 25, 2023

Thanks! What if we made this an Either of a parsed value or a text to make it more explicit how it could go "wrong" but keep the benefits of the parsed representation otherwise?

@nickhs
Copy link
Collaborator

nickhs commented Mar 23, 2024

hey @Saizan, let me know if you'd like to make those changes otherwise happy to do so! I'll also see if I can get a reliable hallucination and add a test

@Saizan
Copy link
Author

Saizan commented Mar 23, 2024

Feel free to go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants