Open
Conversation
Collaborator
abdullahwaheed
left a comment
abdullahwaheed
left a comment
There was a problem hiding this comment.
overall pretty good work. Here are some suggestion:
- Please take a look at
pylint. its a linter for python. in the future assignments, we will be imposing pylint to make sure our code meet pep-8 style guide for python - PR title should be concise and descriptive and you should add a short PR description describing what the PR is about.
- Commit your code whenever you add a functionality. e.g. when you have setup project for the first time, that should be first commit. When you added models and migration, that should be second commit.
- Commit message should be meaningful and should follow these conventions
removed redundant comments fixed unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add core app and user authentication. App include; book, loan, and author models and their migrations, views, and URLs.
Why?
These changes complete the basic library CRUD and authentication.
How
User authentication is implemented using Djoser and simplejwt.