Massive error wiping and re-architecturing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the compiler is the one that checks the language is supported, we don't need to check it ourselves.
It has to be a cplusplus compiler to compile this file...
It's faster, safer, easier to read and maintain TODO: do the same with all internal classes not only with HTTSDo
ekaitz-zarraga
force-pushed
the
hobeto
branch
from
6ce39ab to
c5751ae
Compare
This uncovered many bugs: - Ambiguous ifs - Unexpected fallthroughs in switches And many more! It's possible that my fixes broke some stuff, as the algorithms are not clear. Also the formatting was so awful this changeset is really ugly. I'm sorry.
ekaitz-zarraga
force-pushed
the
hobeto
branch
from
c5751ae to
2f4a7cc
Compare
ekaitz-zarraga
changed the title
|
So the parameter control is just too convoluted, and it uses contradicting names ( I think the best is to remove all the Is there any chance to rewrite this in collaboration with you @aholab ? Really cool project anyways! |
C++ does not have a standard encoding for its files, if we write literals with accents, they are considered UTF-8 by some compilers and they get values that are higher than what a `char` can handle. That's why there was an unneeded cast in this block. Using the Latin1 encoding the code has defined, we can deal with all this in `char` range, without errors. I don't really understand why everything is full of characters with tildes, if there's a fantastic `chset.h` that contains all the magic needed to avoid these issues and be portable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using this lib for a personal project and the internals are pretty much a broken mess 😞
I'm trying to fix the broken code and also some weird design decisions.
I open this PR as a WIP. I'll keep updating it if I have time.
Suggestions and improvements are welcome.