feat: add DYN_REQUEST_PLANE=tcp environment variable to SGLang and TensorRT-LLM containers -2 #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsorRT-LLM containers This change adds the DYN_REQUEST_PLANE=tcp environment variable to the SGLang and TensorRT-LLM Dockerfiles, matching the configuration already present in the VLLM Dockerfile. This environment variable switches the request plane communication from NATS to TCP for consistency across all container backends. Changes: - container/Dockerfile.sglang: Add DYN_REQUEST_PLANE=tcp environment variable - container/Dockerfile.trtllm: Add DYN_REQUEST_PLANE=tcp environment variable - container/Dockerfile.vllm: Environment variable already present (reference) - tests/utils/payloads.py: Update metrics validation threshold 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
cherry-picked #4492 on top of #4497
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)