Skip to content

ci: OPS-2135: Push dynamo base image on main merges #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: OPS-2135: Push dynamo base image on main merges #4507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
647364c
Test push dynamo base image
dillon-cullinan Nov 20, 2025
c0c8093
Fix push test
dillon-cullinan Nov 20, 2025
bdea27b
Revert test to merge-ready logic
dillon-cullinan Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions .github/workflows/container-validation-backends.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ jobs:
- { arch: arm64, runner: cpu-arm-r8g-4xlarge }
name: vllm (${{ matrix.platform.arch }})
runs-on: ${{ matrix.platform.runner }}
env:
DYNAMO_BASE_IMAGE: dynamo-base:latest
steps:
- name: Output Node Name
shell: bash
Expand All @@ -157,7 +159,7 @@ jobs:
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
- name: Docker Tag and Push
- name: Push framework runtime image
uses: ./.github/actions/docker-tag-push
with:
local_image: ${{ steps.build-image.outputs.image_tag }}
Expand All @@ -170,6 +172,19 @@ jobs:
azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }}
azure_acr_user: ${{ secrets.AZURE_ACR_USER }}
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}
- name: Push dynamo base image
uses: ./.github/actions/docker-tag-push
if: ${{ github.ref_name == 'main' }}
with:
local_image: ${{ env.DYNAMO_BASE_IMAGE }}
push_tag: ai-dynamo/dynamo:${{ github.ref_name }}-dynamo-${{ matrix.platform.arch }}
aws_push: 'true'
azure_push: 'false'
aws_account_id: ${{ secrets.AWS_ACCOUNT_ID }}
aws_default_region: ${{ secrets.AWS_DEFAULT_REGION }}
azure_acr_hostname: ${{ secrets.AZURE_ACR_HOSTNAME }}
Copy link
Contributor

@pvijayakrish pvijayakrish Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove the azure credentials from here. Only AWS credentials are needed if azure_push is false.

Copy link
Contributor Author

@dillon-cullinan dillon-cullinan Nov 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. This change does not actually effect functionality.

For the sake of not running through CI again, I will make this commit in the followup PR, unless I must make another commit for a diff reason: #4535

azure_acr_user: ${{ secrets.AZURE_ACR_USER }}
azure_acr_password: ${{ secrets.AZURE_ACR_PASSWORD }}

- name: Run unit tests
if: ${{ matrix.platform.arch != 'arm64' }}
Expand Down Expand Up @@ -224,7 +239,7 @@ jobs:
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

- name: Docker Tag and Push
- name: Push framework runtime image
uses: ./.github/actions/docker-tag-push
with:
local_image: ${{ steps.build-image.outputs.image_tag }}
Expand Down Expand Up @@ -291,7 +306,7 @@ jobs:
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

- name: Docker Tag and Push
- name: Push framework runtime image
uses: ./.github/actions/docker-tag-push
with:
local_image: ${{ steps.build-image.outputs.image_tag }}
Expand Down
4 changes: 2 additions & 2 deletions container/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,8 @@ fi
if [[ -z "${DEV_IMAGE_INPUT:-}" ]]; then
# Follow 2-step build process for all frameworks
if [[ $FRAMEWORK != "NONE" ]]; then
# Define base image tag before using it
DYNAMO_BASE_IMAGE="dynamo-base:${VERSION}"
# Define base image tag before using it, or use predefined image name
DYNAMO_BASE_IMAGE=${DYNAMO_BASE_IMAGE:-dynamo-base:$VERSION}
# Start base image build
echo "======================================"
echo "Starting Build 1: Base Image"
Expand Down
Loading