-
Notifications
You must be signed in to change notification settings - Fork 720
chore: bump nixl 0.8.0 #4528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: bump nixl 0.8.0 #4528
Conversation
| SGLANG_BASE_IMAGE="nvcr.io/nvidia/cuda-dl-base" | ||
| SGLANG_BASE_IMAGE_TAG="25.01-cuda12.8-devel-ubuntu24.04" | ||
|
|
||
| NIXL_REF=0.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If vLLM 0.11.2 docker build shows dependency on nixl>=0.6.0, then wouldn't 0.7.1 work as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but the latest vLLM docker resolves to the latest NIXL, so depends on whether we want complete parity or to just satisfy the reqs
| # NIXL configuration | ||
| ARG NIXL_UCX_REF=v1.19.0 | ||
| ARG NIXL_REF=0.7.1 | ||
| ARG NIXL_UCX_REF=v1.20.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to bump ucx as well for the 0.8.0 version? We haven't in the past bumps so just checking to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we "need" to -- this is my first time doing a Dynamo dependency bump, so @alec-flowers would know better. The 0.8.0 changelog ai-dynamo/nixl@0.7.1...0.8.0 shows a UCX bump. It's not mentioned as a breaking change in the NIXL release notes https://github.com/ai-dynamo/nixl/releases/tag/0.8.0 though.
Overview:
vLLM 0.11.2 docker build shows dependency on
nixl>=0.6.0, which resolves to 0.8.0.This PR updates NIXL to 0.8.0; keeping it separate from the vLLM bump PR (#4476) since this affects the base container used by all frameworks.
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)